Add jenkins benchmark job for cluster endpoint runs #4579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Divya Madala <divyaasm@amazon.com>
Divyaasm
requested review from
dblock,
peterzhuamazon,
bbarani,
gaiksaya,
rishabh6788,
zelinh,
jordarlu,
prudhvigodithi and
tianleh
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4579 +/- ##
==========================================
+ Coverage 92.17% 92.40% +0.23%
==========================================
Files 192 193 +1
Lines 6297 6317 +20
==========================================
+ Hits 5804 5837 +33
+ Misses 493 480 -13 ☔ View full report in Codecov by Sentry. |
rishabh6788
reviewed
Mar 28, 2024
| trim: true | ||
| ) | ||
| string( | ||
| name: 'ADDITIONAL_CONFIG', |
There was a problem hiding this comment.
This is related to opensearch-cluster-cdk, not required here.
rishabh6788
reviewed
Mar 28, 2024
| trim: true | ||
| ) | ||
| booleanParam( | ||
| name: 'CLUSTER_WITH_SECURITY', |
There was a problem hiding this comment.
nit: rename to SECURITY_ENABLED?
rishabh6788
reviewed
Mar 28, 2024
| binding.setVariable('ARTIFACT_DOWNLOAD_ROLE_NAME', 'Dummy_Download_Role') | ||
| binding.setVariable('AWS_ACCOUNT_PUBLIC', 'dummy_account') | ||
| binding.setVariable('CLUSTER_ENDPOINT', 'opensearch-ABCxdfdfhyfk.com') | ||
| binding.setVariable('CLUSTER_WITH_SECURITY', true) |
There was a problem hiding this comment.
Can you please add one more test with security disabled?
Signed-off-by: Divya Madala <divyaasm@amazon.com>
Signed-off-by: Divya Madala <divyaasm@amazon.com>
Signed-off-by: Divya Madala <divyaasm@amazon.com>
rishabh6788
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add jenkins benchmark job for cluster endpoint runs
Issues Resolved
Requires opensearch-project/opensearch-build-libraries#400
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.