Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add errors='replace' handling for execute methods #4564

Merged

Conversation

peterzhuamazon
Copy link
Member

Description

Add errors='replace' handling for execute methods

Issues Resolved

Closes #4563

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Copy link
Collaborator

@rishabh6788 rishabh6788 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.17%. Comparing base (4451d00) to head (6969cdb).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4564   +/-   ##
=======================================
  Coverage   92.17%   92.17%           
=======================================
  Files         192      192           
  Lines        6297     6297           
=======================================
  Hits         5804     5804           
  Misses        493      493           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peterzhuamazon peterzhuamazon merged commit 5205479 into opensearch-project:main Mar 25, 2024
13 checks passed
@peterzhuamazon peterzhuamazon deleted the windows-unicode-errors branch March 25, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

[BUG] Windows integTest stuck on executing integtest.sh commands
2 participants