Ensure that artifact url is valid for Windows dist manifest

[peterzhuamazon]

Description

Ensure that artifact url is valid for Windows dist manifest

Issues Resolved

Closes #4506

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.19%. Comparing base (476a84a) to head (af91be5).
Report is 3 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #4508   +/-   ##
=======================================
  Coverage   92.19%   92.19%           
=======================================
  Files         192      192           
  Lines        6292     6292           
=======================================
  Hits         5801     5801           
  Misses        491      491           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dblock]

This works around the problem, but where does it come from in the first place? Somewhere you get a path separator instead of a / that's platform specific, but should actually be a /.

[peterzhuamazon]

This works around the problem, but where does it come from in the first place? Somewhere you get a path separator instead of a / that's platform specific, but should actually be a /.

It is coming from the build manifest of windows, where everything is using \ due to local path on windows is using \ instead of /.

[dblock]

@peterzhuamazon I understand, however the replacement should happen at the time when the value is passed into anything that takes a relative url, which is likely in a different/higher level place.