-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a validation stage before triggering the Integration tests for OS and OSD #4481
Conversation
Signed-off-by: Divya Madala <divyaasm@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4481 +/- ##
=======================================
Coverage 92.19% 92.19%
=======================================
Files 192 192
Lines 6292 6292
=======================================
Hits 5801 5801
Misses 491 491 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to add a param so that if people want to skip validation before integ-test? Since this would likely take some time to complete.
Yes we can do that, but validation workflow takes upto 5 mins extra time which is very minimal. Can I make the validation step optional or keep it as a mandatory stage? |
Adding @rishabh6788 @prudhvigodithi into the above discussion as well ^^ Thanks. |
Signed-off-by: Divya Madala <divyaasm@amazon.com>
Signed-off-by: Divya Madala <divyaasm@amazon.com>
60e28d5
to
8349d74
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Divyaasm
Description
Currently the integration tests are trigerred for the given component list irrespective of whether the built distributions are valid or not.
Add a stage to Validate artifacts before triggering the integ tests.
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.