Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a validation stage before triggering the Integration tests for OS and OSD #4481

Merged
merged 3 commits into from
Feb 28, 2024

Conversation

Divyaasm
Copy link
Collaborator

Description

Currently the integration tests are trigerred for the given component list irrespective of whether the built distributions are valid or not.
Add a stage to Validate artifacts before triggering the integ tests.

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Divya Madala <divyaasm@amazon.com>
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.19%. Comparing base (6cb96d5) to head (8349d74).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4481   +/-   ##
=======================================
  Coverage   92.19%   92.19%           
=======================================
  Files         192      192           
  Lines        6292     6292           
=======================================
  Hits         5801     5801           
  Misses        491      491           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@peterzhuamazon peterzhuamazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add a param so that if people want to skip validation before integ-test? Since this would likely take some time to complete.

@Divyaasm
Copy link
Collaborator Author

Is it possible to add a param so that if people want to skip validation before integ-test? Since this would likely take some time to complete.

Yes we can do that, but validation workflow takes upto 5 mins extra time which is very minimal. Can I make the validation step optional or keep it as a mandatory stage?
@bbarani thoughts?

@peterzhuamazon
Copy link
Member

peterzhuamazon commented Feb 27, 2024

Adding @rishabh6788 @prudhvigodithi into the above discussion as well ^^
It might use some more executors just for this.

Thanks.

Signed-off-by: Divya Madala <divyaasm@amazon.com>
Signed-off-by: Divya Madala <divyaasm@amazon.com>
Copy link
Member

@peterzhuamazon peterzhuamazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Divyaasm

@Divyaasm Divyaasm merged commit 05ac224 into opensearch-project:main Feb 28, 2024
12 checks passed
@Divyaasm Divyaasm deleted the integ-validate branch April 8, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants