Update jenkinsjob for Validation Workflow #4473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Divya Madala <divyaasm@amazon.com>
Divyaasm
requested review from
dblock,
peterzhuamazon,
bbarani,
gaiksaya,
rishabh6788,
zelinh,
jordarlu,
prudhvigodithi and
tianleh
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4473 +/- ##
==========================================
- Coverage 92.19% 91.94% -0.26%
==========================================
Files 192 192
Lines 6292 6292
==========================================
- Hits 5801 5785 -16
- Misses 491 507 +16 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Hi @Divyaasm
- Do we need to change the lib version?
- Please see a few comments here. Thanks.
Yes we need to bump the version first and change the libversion the jenkinsjob |
Signed-off-by: Divya Madala <divyaasm@amazon.com>
peterzhuamazon
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added support for more arguments and support for new distribution validation
Issues resolved:
#4424
Related PR:
opensearch-project/opensearch-build-libraries#388
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.