Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build failure issue operation #4401

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Fix build failure issue operation #4401

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions jenkins/opensearch-dashboards/distribution-build.jenkinsfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,8 @@ pipeline {
defaultValue: true
)
booleanParam(
name: 'CREATE_GITHUB_ISSUE',
description: 'To create a github issue for failing component or not.',
name: 'UPDATE_GITHUB_ISSUE',
description: 'To create/close/update a github issue for all component or not.',
defaultValue: true
)
booleanParam(
Expand Down Expand Up @@ -941,14 +941,10 @@ pipeline {
node(AGENT_LINUX_X64) {
checkout scm
script {
closeBuildSuccessGithubIssue(
message: buildMessage(search: 'Successfully built'),
search: 'Successfully built',
inputManifestPath: "manifests/$INPUT_MANIFEST"
)
if (params.CREATE_GITHUB_ISSUE) {
createBuildFailureGithubIssue(
message: buildMessage(search: 'Error building'),
if (params.UPDATE_GITHUB_ISSUE) {
UpdateBuildFailureIssues(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue with camel case, should be updateBuildFailureIssues.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh no! https://github.com/opensearch-project/opensearch-build-libraries/blob/main/vars/UpdateBuildFailureIssues.groovy

Will fix this in another iteration. Thanks for catching.

failureMessages: buildMessage(search: 'Error building'),
passMessages: buildMessage(search: 'Successfully built'),
inputManifestPath: "manifests/$INPUT_MANIFEST"
)
}
Expand Down
16 changes: 6 additions & 10 deletions jenkins/opensearch/distribution-build.jenkinsfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,8 @@ pipeline {
defaultValue: true
)
booleanParam(
name: 'CREATE_GITHUB_ISSUE',
description: 'To create a github issue for failing component or not.',
name: 'UPDATE_GITHUB_ISSUE',
description: 'To create/close/update a github issue for all component or not.',
defaultValue: true
)
booleanParam(
Expand Down Expand Up @@ -885,14 +885,10 @@ pipeline {
node(AGENT_LINUX_X64) {
checkout scm
script {
closeBuildSuccessGithubIssue(
message: buildMessage(search: 'Successfully built'),
search: 'Successfully built',
inputManifestPath: "manifests/$INPUT_MANIFEST"
)
if (params.CREATE_GITHUB_ISSUE) {
createBuildFailureGithubIssue(
message: buildMessage(search: 'Error building'),
if (params.UPDATE_GITHUB_ISSUE) {
UpdateBuildFailureIssues(
failureMessages: buildMessage(search: 'Error building'),
passMessages: buildMessage(search: 'Successfully built'),
inputManifestPath: "manifests/$INPUT_MANIFEST"
)
}
Expand Down
Loading