Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add platform selection into components #811

Closed
dblock opened this issue Oct 26, 2021 · 0 comments · Fixed by #817
Closed

Add platform selection into components #811

dblock opened this issue Oct 26, 2021 · 0 comments · Fixed by #817
Assignees
@dblock
Labels
enhancement New Enhancement

Comments

@dblock
Copy link
Member

dblock commented Oct 26, 2021

Is your feature request related to a problem? Please describe

Coming from #809 (comment), we had to create two manifests, one for windows and another for linux, to exclude a component from windows.

Describe the solution you'd like

add a way to include a plugin for certain platforms only.

components:
  - name: k-nn
     platforms:
       - linux
       - darwin

Merge the existing manifests.

Describe alternatives you've considered

No response

Additional context

No response
@dblock dblock added enhancement New Enhancement untriaged Issues that have not yet been triaged and removed untriaged Issues that have not yet been triaged labels Oct 26, 2021
@dblock dblock self-assigned this Oct 26, 2021
This was referenced Oct 26, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dblock dblock

Labels
enhancement New Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable components to declare compatible platforms. dblock/opensearch-build
1 participant
@dblock