-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Plugin Check failed when building all plugins on Jenkins and continue-on-error omit failure logs #4625
Comments
The continue-on-error was designed to ignore the errors. If we raise, the program will error out. It won't continue. For opensearch we can see the failed logs in the build.sh step of jenkins. Example: Details
However looking for failure logs in opensearch-dashboards, I don't see any for observability dashboards. Do we need to set some flag to hide warnings from npm side and show actual error? Details
cc: @rishabh6788 |
Error shows:
|
So our check still runs fine, just continue-on-error omit the error stack trace. We should find a way to actually print the error logs without raising and fail directly. Thanks. |
Added a fix:
|
[BUG] Plugin Check failed when building all plugins on Jenkins and continue-on-error omit failure logs
Hi,
When enabling continue-on-error and run all the plugin build for OSD on Jenkins for 2.14.0:
observabilityDashboards
as example, build is success, but check failed. https://build.ci.opensearch.org/job/distribution-build-opensearch-dashboards/7564/observabilityDashboards
by itself it goes to success: https://build.ci.opensearch.org/job/distribution-build-opensearch-dashboards/7566/reportDashboards
with the same issue: https://build.ci.opensearch.org/job/distribution-build-opensearch-dashboards/7569/Still monitoring, the error code is somewhere within this:
Also, the continue-on-error code is actually omitting the failure stacktrace by ignore the
raise
, suggesting still print out the trace but continue after:Thanks.
The text was updated successfully, but these errors were encountered: