Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL encode links in test result files #4569

Closed
Swiddis opened this issue Mar 25, 2024 · 0 comments · Fixed by #4574
Closed

URL encode links in test result files #4569

Swiddis opened this issue Mar 25, 2024 · 0 comments · Fixed by #4574
Labels
enhancement New Enhancement

Comments

@Swiddis
Copy link
Contributor

Swiddis commented Mar 25, 2024

Is your feature request related to a problem? Please describe

Relatively minor issue: when Cypress tests fail and are put in the test report, the links aren't URL encoded, which means spaces in the link cause pyyaml to word wrap and messes with clicking links if trying to navigate through several failing tests.

Describe the solution you'd like

URL encoding the file names in the manifest output generator would make it easier to navigate the test manifest. We could update the linked line that creates the test paths to return [os.path.join(base_path, relative_path, urllib.parse.quote_plus(file)) for file in files].

I'm happy to implement this myself, feel free to assign the issue to me.

Describe alternatives you've considered

No response

Additional context

No response

@Swiddis Swiddis added enhancement New Enhancement untriaged Issues that have not yet been triaged labels Mar 25, 2024
@peterzhuamazon peterzhuamazon removed the untriaged Issues that have not yet been triaged label Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New Enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants