Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Windows bundle manifest is using \ not / in url location #4506

Closed
peterzhuamazon opened this issue Mar 5, 2024 · 0 comments · Fixed by #4508
Closed

[BUG] Windows bundle manifest is using \ not / in url location #4506

peterzhuamazon opened this issue Mar 5, 2024 · 0 comments · Fixed by #4508
Assignees

Comments

@peterzhuamazon
Copy link
Member

[BUG] Windows bundle manifest is using \ not / in url location

See manifest (1).txt.

---
schema-version: '1.1'
build:
  name: OpenSearch Dashboards
  version: 2.12.0
  platform: windows
  architecture: x64
  distribution: zip
  location: https://ci.opensearch.org/ci/dbc/distribution-build-opensearch-dashboards/2.12.0/7326/windows/x64/zip/dist/opensearch-dashboards/opensearch-dashboards-2.12.0-windows-x64.zip
  id: '7326'
components:
  - name: OpenSearch-Dashboards
    repository: https://github.com/opensearch-project/OpenSearch-Dashboards.git
    ref: '2.12'
    commit_id: 9ec9a677af5f28e5450926ce07e9d6c3273717a7
    location: https://ci.opensearch.org/ci/dbc/distribution-build-opensearch-dashboards/2.12.0/7326/windows/x64/zip/builds/opensearch-dashboards/dist\opensearch-dashboards-min-2.12.0-windows-x64.zip
......

It is due to build manifest saving relative path as dist\<>.zip or plugins\<>.zip for windows. We cannot fix this on root as the manifest can be either local path based, or url based for official release through Jenkins.

Therefore, we need to fix the bundle_url_location.py directly.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

1 participant