[Bug]: Dashboards Integ test cypress video inconsistent with configuration

[zelinh]

Describe the bug

We have seen the cypress video is showing different results as the test logs.

For example, this log is showing 4_panels.spec.js is failing, however, if we click into its component yml file
https://ci.opensearch.org/ci/dbc/integ-test-opensearch-dashboards/2.12.0/7218/linux/x64/tar/test-results/5364/integ-test/observabilityDashboards/with-security/observabilityDashboards.yml
and the corresponding video, it actually shows passing.

According to more research, those videos for configuration with-security are all without-security and they are the same as our videos from without-security. It seems like the cypress videos are overwriting previous-configuration videos so all cypress videos from previous configuration are not recorded properly.

To reproduce

For example, this video for with-security is the same as this one for without-security even they have different links.

[zelinh]

According to my explore, the reason is that when we run FT repo, videos for different configurations are not distinguished and stored in the same location.

opensearch-build/src/test_workflow/integ_test/integ_test_suite_opensearch_dashboards.py

Lines 140 to 145 in 5b4f11f

	def test_artifact_files(self) -> dict:
	return {
	"cypress-videos": os.path.join(self.repo_work_dir, "cypress", "videos"),
	"cypress-screenshots": os.path.join(self.repo_work_dir, "cypress", "screenshots"),
	"cypress-report": os.path.join(self.repo_work_dir, "cypress", "results"),
	}

When we try to record these cypress videos after running integ tests for both configurations, we only save the location of these videos for different configurations but within the directory, they are the same (and always the results from later run configuration).

opensearch-build/src/test_workflow/integ_test/integ_test_runner.py

Line 48 in 5b4f11f

[self.test_recorder.test_results_logs.save_test_result_data(result_data) for result_data in test_suite.result_data]

We could add another step to record test results after each configuration so that those results won't be overwrote.

I will be drafting a PR pretty soon on this fix.

[zelinh]

This issue is reported from @RyanL1997 and I confirmed it's valid. PR is pending for the fix.

[zelinh]

This bug should have been fixed. Closing this issue.