Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Plugins CI] Generate 1.4.0 artifact to unblock CIs #4392

Closed
DarshitChanpura opened this issue Jan 31, 2024 · 9 comments
Closed

[Plugins CI] Generate 1.4.0 artifact to unblock CIs #4392

DarshitChanpura opened this issue Jan 31, 2024 · 9 comments
Assignees

Comments

@DarshitChanpura
Copy link
Member

Security-dashboards-plugin CI for 1.x branch is currently blocked due to security plugin 1.4.0.0 artifact not being available[1]. All security-dashboards plugin PRs currently pointing to 1.x branch are blocked.

I understand that the 1.3 is the last minor version in 1.x line and there will not be 1.4.0 however OpenSearch and OpenSearch Dashboards seems to already been incremented to 1.4.0. So this is request to publish 1.4.0 artifact to unblock merging changes in 1.x line to then be backported to 1.3.

If we think that is not the best solution, an alternative approach is to announce it to plugins to stop basing PRs against 1.x, and directly push the changes to 1.3 which will unblock changes going into 1.3.

Thoughts?

[1] - opensearch-project/security-dashboards-plugin#1750

@github-actions github-actions bot added the untriaged Issues that have not yet been triaged label Jan 31, 2024
@DarshitChanpura DarshitChanpura changed the title Generate 1.4.0 artifact to unblock CIs [Plugins CI] Generate 1.4.0 artifact to unblock CIs Jan 31, 2024
@prudhvigodithi
Copy link
Member

[Triage]
Hey @DarshitChanpura I have added 1.x series to version increment automation this should have PR's created with 1.4.0 version increment.
Thanks

@prudhvigodithi prudhvigodithi removed the untriaged Issues that have not yet been triaged label Feb 1, 2024
@prudhvigodithi prudhvigodithi self-assigned this Feb 1, 2024
@DarshitChanpura
Copy link
Member Author

DarshitChanpura commented Feb 5, 2024

Hey @DarshitChanpura I have added 1.x series to version increment automation this should have PR's created with 1.4.0 version increment.
Thanks

Thank you @prudhvigodithi . This did create PRs however the CI build seems to not have run for 1.4.0 even though security plugin is added to 1.4 manifest which has caused the artifact to not be generated, and hence the CI is still failing due to missing artifact

@jordarlu
Copy link
Contributor

jordarlu commented Mar 15, 2024

Hi, @DarshitChanpura, sorry for the late, the opensearch-security-1.4.0.0 is in place now,, could you trigger the test again on your PR to see how it works? thanks!

@DarshitChanpura
Copy link
Member Author

DarshitChanpura commented Mar 19, 2024

@derek-ho
Copy link
Contributor

@jordarlu @prudhvigodithi windows 1.4 artifacts are not available yet. This is blocking this PR: opensearch-project/security-dashboards-plugin#1951, can we generate those?

@gaiksaya
Copy link
Member

Hi @derek-ho @DarshitChanpura was this issue resolved?

@DarshitChanpura
Copy link
Member Author

@gaiksaya
Copy link
Member

@DarshitChanpura
Copy link
Member Author

yes, I can too. Thank you for fixing it @gaiksaya !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants