Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Build Failure issues often open/close within minutes #4357

Closed
1 task
gaiksaya opened this issue Jan 18, 2024 · 1 comment · Fixed by opensearch-project/opensearch-build-libraries#380 or #4401
Closed
1 task
Assignees
Labels
bug Something isn't working

Comments

@gaiksaya
Copy link
Member

gaiksaya commented Jan 18, 2024

Describe the bug

Autocut build failure issues creating as an action item for component teams do not honor the platform, architecture, etc. The current logic blinding parses the error messages and closes/re-opens the issues.
See: https://github.com/issues?q=is%3Aopen+is%3Aissue+archived%3Afalse+user%3Aopensearch-project+label%3Aautocut+%22%5BAUTOCUT%5D+Distribution+Build+Failed+for+%22

To reproduce

Observe the log messages in distribution pipeline

Expected behavior

Only close the issue if there is no recent failure on any stages.

Screenshots

image

Acceptance Criterias

  • Only close the issue if there is no recent failure on any stages
@gaiksaya gaiksaya added bug Something isn't working untriaged Issues that have not yet been triaged labels Jan 18, 2024
@gaiksaya
Copy link
Member Author

Had a discussion with @prudhvigodithi
This is caused because both libraries are called one after the other here: https://github.com/opensearch-project/opensearch-build/blob/main/jenkins/opensearch/distribution-build.jenkinsfile#L782-L792

One way to fix this is compare the passing components with the failed ones and only close the delta.

Passing components ArrrayList: https://github.com/opensearch-project/opensearch-build-libraries/blob/main/vars/closeBuildSuccessGithubIssue.groovy#L19
Failing components ArrayList: https://github.com/opensearch-project/opensearch-build-libraries/blob/main/vars/createBuildFailureGithubIssue.groovy#L28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
2 participants