You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
help="Given previous build artifacts are present, build incrementally.",
)
Only one argument can be passed into the build workflow at the same time.
Ideally we want both arguments working at the same time in some circumstances.
Describe the solution you'd like
Have both arguments working in the build workflow. If --component <name> --incremental is passed, it should compare the component from the previous build manifest and make a decision to either rebuilt or skip using the diff.
Describe alternatives you've considered
Keep them mutually exclusive.
Additional context
No response
The text was updated successfully, but these errors were encountered:
This issue is actually an enhancement based on the behavior of incremental build implementation.
Currently we don't have a ideal logic for how to handle both component and incremental arguments at the same time, so we make them mutually exclusive.
When user specifies incremental argument, the build workflow will look into the previous build manifest and find out the rebuilding components with commit changes. The component argument will not be used in this case.
I think we may want to explore more on this option to enable both arguments in the future.
Is your feature request related to a problem? Please describe
Currently we have
--component
and--incremental
as mutually exclusive arguments in our build workflow.opensearch-build/src/build_workflow/build_args.py
Lines 99 to 115 in 810f742
Only one argument can be passed into the build workflow at the same time.
Ideally we want both arguments working at the same time in some circumstances.
Describe the solution you'd like
Have both arguments working in the build workflow. If
--component <name> --incremental
is passed, it should compare the component from the previous build manifest and make a decision to either rebuilt or skip using the diff.Describe alternatives you've considered
Keep them mutually exclusive.
Additional context
No response
The text was updated successfully, but these errors were encountered: