Fix h5py build issues encountered during the release process #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Govind Kamat <govkamat@amazon.com>
gkamat
requested review from
IanHoang,
beaioun,
cgchinmay,
rishabh6788 and
VijayanB
as code owners
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 27, 2024
Signed-off-by: Govind Kamat <govkamat@amazon.com> (cherry picked from commit ee48063) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
finnroblin
pushed a commit
to finnroblin/opensearch-benchmark
that referenced
this pull request
Jul 19, 2024
…rch-project#574) Signed-off-by: Govind Kamat <govkamat@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
h5pywheels are supplied for different versions on Intel and ARM architectures, and the build from source of this package is not straightforward, leading to issues during the OSB release. This change ensures that a source build is not attempted.Issues Resolved
#570
Testing
Built OSB manually on both
x86andaarch64.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.