Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming components: test-procedure to scenario #439

Closed

Conversation

beaioun
Copy link
Collaborator

@beaioun beaioun commented Jan 12, 2024

Description

Renaming all occurrences of the name test-procedure and test_procedure to scenario, class name TestProcedure to Scenario

Issues Resolved

issue #308
same as #421

Testing

  • New functionality includes testing

The changes were tested against an OpenSerach cluster version 1.3.2 for the already merged changes to OS-1 branch on openserach-benchmark-workloads PR149

2024-01-12 01:19:41,839 ActorAddr-(T|:46687)/PID:15931 osbenchmark.test_execution_orchestrator INFO Automatically derived distribution version [1.3.2]
2024-01-12 01:19:42,155 ActorAddr-(T|:46687)/PID:15931 osbenchmark.utils.repo INFO Checking out [OS-1] in [/home/will/.benchmark/benchmarks/workloads/default] for distribution version [1.3.2].
2024-01-12 01:19:42,192 ActorAddr-(T|:46687)/PID:15931 osbenchmark.utils.process INFO Switched to a new branch 'OS-1'
Branch 'OS-1' set up to track remote branch 'OS-1' from 'origin'.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

dosa-chammandi and others added 19 commits November 7, 2023 11:51
…n with RequestsHttpConnection (opensearch-project#411)

Signed-off-by: beaioun <mshi@ucsd.edu>
Signed-off-by: Mingyang Shi <mshi@ucsd.edu>
Signed-off-by: Chinmay Gadgil <chinmay5j@gmail.com>
…#423)

Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
…earch-project#427)

Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
Signed-off-by: Sai Medhini Reddy Maryada <117196660+saimedhi@users.noreply.github.com>
Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
Signed-off-by: beaioun <mshi@ucsd.edu>
…e failed integration tests from the last commit

Signed-off-by: beaioun <mshi@ucsd.edu>
…etter align with common understandings

Signed-off-by: beaioun <mshi@ucsd.edu>
…mple command

Signed-off-by: beaioun <mshi@ucsd.edu>
…anches with type names

Signed-off-by: beaioun <mshi@ucsd.edu>
@IanHoang IanHoang changed the title [DUPLICATE] Renaming components: test-procedure to scenario Renaming components: test-procedure to scenario Jan 19, 2024
beaioun and others added 4 commits January 23, 2024 14:12
Signed-off-by: beaioun <mshi@ucsd.edu>
…he end of a workload. (opensearch-project#441)

Signed-off-by: Peter Alfonsi <petealft@amazon.com>
Co-authored-by: Peter Alfonsi <petealft@amazon.com>
… from workload.json (opensearch-project#446)

Signed-off-by: Ian Hoang <hoangia@amazon.com>
Co-authored-by: Ian Hoang <hoangia@amazon.com>
@IanHoang
Copy link
Collaborator

Note: Tests are failing due to workloads repository mainline not having changes. If these changes are added to mainline, they would be introducing breaking changes.

As an alternative, exploring using github actions in forked repository to test the changes

…ay (opensearch-project#449)

Signed-off-by: Peter Alfonsi <petealft@amazon.com>
Co-authored-by: Peter Alfonsi <petealft@amazon.com>
gkamat and others added 6 commits February 2, 2024 12:07
…mon Solutions (opensearch-project#448)

Signed-off-by: Ian Hoang <hoangia@amazon.com>
Co-authored-by: Ian Hoang <hoangia@amazon.com>
Signed-off-by: saimedhi <saimedhi@amazon.com>
Signed-off-by: Ian Hoang <hoangia@amazon.com>
Signed-off-by: Ian Hoang <hoangia@amazon.com>
Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
@beaioun
Copy link
Collaborator Author

beaioun commented Feb 6, 2024

The changes were tested in this github action using my forked repository as default workload repository URL. I had cherry picked the changes from OS-1 (PR #149) to OS-2 and main to match the two versions: 1.3.9, 2.5.0 that this action is running on. The only error now is that the workload-revision points to a past commit in the list_test.py when it tries to list the workloads but it should be safe to ignore. The changes are ready to be populated in opensearch-benchmark-workloads and then this PR should be good to go. @IanHoang

@beaioun beaioun self-assigned this Feb 6, 2024
Signed-off-by: Mingyang Shi <94433735+beaioun@users.noreply.github.com>
@IanHoang IanHoang changed the base branch from main to renaming-components February 7, 2024 21:24
beaioun and others added 2 commits February 12, 2024 14:00
Signed-off-by: Mingyang Shi <94433735+beaioun@users.noreply.github.com>
Signed-off-by: beaioun <mshi@ucsd.edu>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you check if you have rebased from latest changes. Not sure why this file is included as part of this change

@IanHoang IanHoang added the 2.0.0 label Apr 3, 2024
@IanHoang
Copy link
Collaborator

IanHoang commented Apr 9, 2024

Closing this PR for now. We will readdress this when gearing up for 2.0.0 release

@IanHoang IanHoang closed this Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants