Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add target_index_settings to rollup specification #822

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

MrChaos1993
Copy link

Description

Allow to create index with specified settings during rollup

Issues Resolved

opensearch-project/index-management#1376

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dblock
Copy link
Member

dblock commented Feb 20, 2025

@MrChaos1993 amend your commit with -s to pass DCO

Exercise an API in a test that returns this data, see https://github.com/opensearch-project/opensearch-api-specification/blob/main/TESTING_GUIDE.md

Copy link
Contributor

Changes Analysis

Commit SHA: 2ef7740
Comparing To SHA: 5ed668d

API Changes

Summary

└─┬Components
  └─┬rollups._common___Rollup
    └──[➕] properties (60999:9)

Document Element Total Changes Breaking Changes
components 1 0
  • Total Changes: 1
  • Additions: 1

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/13521033472/artifacts/2650104708

API Coverage

Before After Δ
Covered (%) 663 (64.94 %) 663 (64.94 %) 0 (0 %)
Uncovered (%) 358 (35.06 %) 358 (35.06 %) 0 (0 %)
Unknown 45 45 0

@nhtruong
Copy link
Collaborator

Test suites that involve the new test failed with Expected status 201, but received 400: application/json. Invalid field [target_index_settings] found in Rollup.

Don't forget to add a line in the CHANGELOG.md describing the change from this PR.

Signed-off-by: Aleksandr Tuliakov <tulyakov@yandex-team.ru>
Signed-off-by: Aleksandr Tuliakov <tulyakov@yandex-team.ru>
Signed-off-by: Aleksandr Tuliakov <tulyakov@yandex-team.ru>
@MrChaos1993 MrChaos1993 force-pushed the feat/rollup-index-settings branch from 2ef7740 to 9def519 Compare February 26, 2025 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants