Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simple pattern tokenizers #820

Merged

Conversation

Xtansia
Copy link
Collaborator

@Xtansia Xtansia commented Feb 19, 2025

Description

Add simple pattern tokenizers

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Feb 19, 2025

Changes Analysis

Commit SHA: ca43f3d
Comparing To SHA: 60a9b3b

API Changes

Summary

└─┬Components
  ├──[➕] schemas (41536:7)
  ├──[➕] schemas (41549:7)
  └─┬_common.analysis___TokenizerDefinition
    ├──[➕] oneOf (40721:7)
    ├──[➕] oneOf (41580:7)
    ├─┬ONEOF
    │ └──[🔀] $ref (41550:9)❌ 
    └─┬ONEOF
      └──[🔀] $ref (41537:9)❌ 

Document Element Total Changes Breaking Changes
components 6 2
  • BREAKING Changes: 2 out of 6
  • Modifications: 2
  • Additions: 4
  • Breaking Modifications: 2

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/13423099679/artifacts/2619617234

API Coverage

Before After Δ
Covered (%) 663 (64.94 %) 663 (64.94 %) 0 (0 %)
Uncovered (%) 358 (35.06 %) 358 (35.06 %) 0 (0 %)
Unknown 45 45 0

Signed-off-by: Thomas Farr <tsfarr@amazon.com>
@Xtansia Xtansia force-pushed the feat/simple_pattern_tokenizers branch from 6ab5d18 to ca43f3d Compare February 19, 2025 21:55
Copy link
Contributor

Spec Test Coverage Analysis

Total Tested
595 593 (99.66 %)

@dblock dblock merged commit 5ed668d into opensearch-project:main Feb 20, 2025
30 checks passed
@Xtansia Xtansia deleted the feat/simple_pattern_tokenizers branch February 20, 2025 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants