Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define Suggester types #817

Merged
merged 1 commit into from
Feb 18, 2025
Merged

Conversation

Xtansia
Copy link
Collaborator

@Xtansia Xtansia commented Feb 17, 2025

Description

Define Suggester types

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Feb 17, 2025

Changes Analysis

Commit SHA: d12d9a4
Comparing To SHA: ae60349

API Changes

Summary

├─┬Paths
│ ├─┬/_search
│ │ ├─┬GET
│ │ │ └──Parameters
│ │ └─┬POST
│ │   └──Parameters
│ └─┬/{index}/_search
│   ├─┬GET
│   │ └──Parameters
│   └─┬POST
│     └──Parameters
└─┬Components
  ├──[➕] schemas (47653:7)
  ├──[➕] schemas (47165:7)
  ├──[➕] schemas (47632:7)
  ├──[➕] schemas (47227:7)
  ├──[➕] schemas (46704:7)
  ├──[➕] schemas (47215:7)
  ├──[➕] schemas (47234:7)
  ├──[➕] schemas (46606:7)
  ├──[➕] schemas (47620:7)
  ├──[➕] schemas (47579:7)
  ├──[➕] schemas (47571:7)
  ├──[➕] schemas (47173:7)
  ├──[➕] schemas (47534:7)
  ├──[➕] schemas (46761:7)
  ├──[➕] schemas (47671:7)
  ├──[➕] schemas (46871:7)
  ├──[➕] schemas (46670:7)
  ├──[➕] schemas (47273:7)
  ├─┬_core.search___Context
  │ └─┬ONEOF
  │   └──[➕] title (46756:18)
  ├─┬_core.search___AggregationProfileDebug
  │ ├──[➖] properties (46609:9)❌ 
  │ ├──[➖] properties (46616:9)❌ 
  │ ├──[➖] properties (46613:9)❌ 
  │ ├──[➖] properties (46606:9)❌ 
  │ ├──[➖] properties (46603:9)❌ 
  │ └─┬delegate_debug
  │   └──[🔀] $ref (46606:13)❌ 
  ├─┬_core.search___Suggester
  │ └──[➕] additionalProperties (47616:9)❌ 
  ├─┬_core.search___TrackHits
  │ ├─┬ONEOF
  │ │ └──[➕] title (47750:18)
  │ └─┬ONEOF
  │   └──[➕] title (47752:18)
  ├─┬_core.search___PhraseSuggestOption
  │ └─┬score
  │   └──[🔀] format (47289:19)❌ 
  ├─┬_core.search___TotalHitsRelation
  │ ├──[➖] enum (47441:11)❌ 
  │ ├──[➖] enum (47440:11)❌ 
  │ ├──[➖] type (47438:13)❌ 
  │ ├──[➕] oneOf (47737:11)
  │ └──[➕] oneOf (47740:11)
  ├─┬_core.search___TermSuggestOption
  │ ├──[➖] required (47423:11)❌ 
  │ ├─┬freq
  │ │ ├──[🔀] type (47715:17)❌ 
  │ │ └──[🔀] format (47716:19)❌ 
  │ └─┬score
  │   └──[🔀] format (47713:19)❌ 
  └─┬_core.search___FetchProfileBreakdown
    ├─┬load_source
    │ ├──[🔀] type (46820:17)❌ 
    │ └──[➕] format (46821:19)❌ 
    └─┬load_source_count
      ├──[🔀] type (46823:17)❌ 
      └──[➕] format (46824:19)❌ 

Document Element Total Changes Breaking Changes
paths 0 0
components 42 19
  • BREAKING Changes: 19 out of 42
  • Modifications: 7
  • Removals: 9
  • Additions: 26
  • Breaking Removals: 9
  • Breaking Modifications: 7
  • Breaking Additions: 3

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/13362627130/artifacts/2600835971

API Coverage

Before After Δ
Covered (%) 663 (64.94 %) 663 (64.94 %) 0 (0 %)
Uncovered (%) 358 (35.06 %) 358 (35.06 %) 0 (0 %)
Unknown 45 45 0

Copy link
Contributor

Spec Test Coverage Analysis

Total Tested
595 593 (99.66 %)

Signed-off-by: Thomas Farr <tsfarr@amazon.com>
@dblock dblock merged commit 5697cbd into opensearch-project:main Feb 18, 2025
29 checks passed
@Xtansia Xtansia deleted the feat/remainder branch February 18, 2025 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants