Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Query DSL schemas #813

Merged
merged 2 commits into from
Feb 10, 2025
Merged

Conversation

Xtansia
Copy link
Collaborator

@Xtansia Xtansia commented Feb 9, 2025

Description

Fix Query DSL schemas

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Thomas Farr <tsfarr@amazon.com>
Copy link
Contributor

github-actions bot commented Feb 9, 2025

Changes Analysis

Commit SHA: e537816
Comparing To SHA: b95d90e

API Changes

Summary

├─┬Paths
│ ├─┬/_index_template/_simulate_index/{name}
│ │ └─┬POST
│ │   └─┬Responses
│ │     └─┬200
│ │       └─┬application/json
│ │         └─┬Schema
│ │           ├──[➕] properties (31556:15)
│ │           └──[➕] properties (31560:15)
│ ├─┬/_tasks/{task_id}/_cancel
│ │ └─┬POST
│ │   └──Parameters
│ └─┬/_delete_by_query/{task_id}/_rethrottle
│   └─┬POST
│     └──Parameters
└─┬Components
  ├──[➖] schemas (45365:7)❌ 
  ├──[➖] schemas (43656:7)❌ 
  ├──[➖] schemas (43399:7)❌ 
  ├──[➖] schemas (43395:7)❌ 
  ├──[➖] schemas (44383:7)❌ 
  ├──[➖] schemas (43403:7)❌ 
  ├──[➖] schemas (43660:7)❌ 
  ├──[➖] schemas (44410:7)❌ 
  ├──[➖] schemas (43703:7)❌ 
  ├──[➖] schemas (43476:7)❌ 
  ├──[➖] schemas (43461:7)❌ 
  ├──[➕] schemas (43400:7)
  ├──[➕] schemas (44442:7)
  ├──[➕] schemas (43724:7)
  ├──[➕] schemas (43527:7)
  ├──[➕] schemas (43451:7)
  ├──[➕] schemas (43770:7)
  ├──[➕] schemas (43685:7)
  ├──[➕] schemas (43412:7)
  ├──[➕] schemas (45469:7)
  ├──[➕] schemas (45052:7)
  ├──[➕] schemas (44473:7)
  ├──[➕] schemas (44064:7)
  ├─┬_common.query_dsl___GeoDistanceQuery
  │ ├─┬ALLOF
  │ │ └──[🔀] $ref (43699:11)❌ 
  │ └─┬ALLOF
  │   └──[🔀] $ref (44594:13)❌ 
  ├─┬_common.query_dsl___GeoPolygonQuery
  │ ├─┬ALLOF
  │ │ └──[🔀] $ref (44594:13)❌ 
  │ └─┬ALLOF
  │   └──[🔀] $ref (43735:11)❌ 
  ├─┬_common.query_dsl___RangeQuery
  │ ├──[➖] oneOf (43403:7)❌ 
  │ ├──[➖] oneOf (44383:7)❌ 
  │ ├──[➕] allOf (44953:7)
  │ └──[➕] allOf (44949:11)
  ├─┬_common.query_dsl___GeoBoundingBoxQuery
  │ └─┬ALLOF
  │   └──[➕] propertyNames (43678:13)❌ 
  ├─┬_common.query_dsl___TermsQuery
  │ ├─┬ALLOF
  │ │ └──[🔀] $ref (44594:13)❌ 
  │ └─┬ALLOF
  │   └──[🔀] $ref (45363:11)❌ 
  ├─┬_common.query_dsl___DistanceFeatureQuery
  │ ├──[➖] oneOf (43660:7)❌ 
  │ ├──[➖] oneOf (43399:7)❌ 
  │ ├──[➕] allOf (44594:7)
  │ └──[➕] allOf (43477:11)
  ├─┬_common.query_dsl___SpanGapQuery
  │ ├──[➕] propertyNames (45205:9)❌ 
  │ └─┬Schema
  │   └──[➕] title (45207:16)
  ├─┬_common.query_dsl___FunctionScoreContainer
  │ └─┬ALLOF
  │   └──[🔀] minProperties (43603:26)❌ 
  ├─┬_common___TaskId
  │ ├──[➕] type (36604:13)❌ 
  │ ├──[➖] oneOf (36599:11)❌ 
  │ └──[➖] oneOf (36598:11)❌ 
  ├─┬_common.query_dsl___ZeroTermsQuery
  │ ├──[➕] enum (45483:11)
  │ └──[➕] enum (45485:11)
  ├─┬_common.query_dsl___GeoShapeQuery
  │ └─┬ALLOF
  │   ├──[➕] propertyNames (43763:13)❌ 
  │   └─┬Schema
  │     └──[🔀] $ref (43770:13)❌ 
  ├─┬_common.query_dsl___XyShapeQuery
  │ └─┬ALLOF
  │   ├──[➕] propertyNames (45462:13)❌ 
  │   ├──[➖] maxProperties (45381:26)❌ 
  │   ├──[➕] properties (45459:13)
  │   └─┬Schema
  │     └──[🔀] $ref (45469:13)❌ 
  ├─┬_common.query_dsl___DecayFunction
  │ ├──[➖] oneOf (43656:7)❌ 
  │ ├──[➖] oneOf (44410:7)❌ 
  │ ├──[➖] oneOf (43395:7)❌ 
  │ ├──[➕] allOf (43446:7)
  │ └──[➕] allOf (43437:11)
  └─┬_common.query_dsl___KnnQuery
    └─┬ALLOF
      ├──[➕] properties (44058:13)
      ├─┬method_parameters
      │ └──[🔀] additionalProperties (44054:37)❌ 
      ├─┬rescore
      │ └──[🔀] $ref (44065:9)❌ 
      └─┬filter
        └──[🔀] $ref (44607:13)❌ 

Document Element Total Changes Breaking Changes
components 61 54
paths 2 0
  • BREAKING Changes: 54 out of 63
  • Modifications: 12
  • Removals: 21
  • Additions: 30
  • Breaking Removals: 21
  • Breaking Modifications: 12
  • Breaking Additions: 5

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/13230815073/artifacts/2561641974

API Coverage

Before After Δ
Covered (%) 663 (64.94 %) 663 (64.94 %) 0 (0 %)
Uncovered (%) 358 (35.06 %) 358 (35.06 %) 0 (0 %)
Unknown 45 45 0

Copy link
Contributor

github-actions bot commented Feb 9, 2025

Spec Test Coverage Analysis

Total Tested
595 593 (99.66 %)

Signed-off-by: Thomas Farr <tsfarr@amazon.com>
@dblock dblock merged commit 22483a2 into opensearch-project:main Feb 10, 2025
30 checks passed
@Xtansia Xtansia deleted the fix/query-dsl branch February 10, 2025 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants