Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed swapped schema references in nodes info API buffer fields #808

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fixed swapped schema references in nodes info API buffer fields #808

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0582674
Fixed swapped schema references in nodes info API buffer fields
hye-on Jan 25, 2025
394be9e
Add version specific schema handling for total_indexing_buffer and to…
hye-on Jan 27, 2025
8f8e6e9
Fix version number format in nodes.info.yaml
hye-on Jan 27, 2025
1622f24
Remove version tags and add notes for schema changes
hye-on Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
- Fixed Memory Circuit Breaker flaky error in ML APIs ([#788](https://github.com/opensearch-project/opensearch-api-specification/pull/788))
- Fixed GeoDistanceSort schema ([#805](https://github.com/opensearch-project/opensearch-api-specification/pull/805))
- Fixed Aggregation schemas([#801](https://github.com/opensearch-project/opensearch-api-specification/pull/801))
- Fixed swapped schema references in nodes info API buffer fields([#808](https://github.com/opensearch-project/opensearch-api-specification/pull/808))

### Changed
- Changed `tasks._common:TaskInfo` and `tasks._common:TaskGroup` to be composed of a `tasks._common:TaskInfoBase` ([#683](https://github.com/opensearch-project/opensearch-api-specification/pull/683))
Expand Down
5 changes: 2 additions & 3 deletions spec/schemas/nodes.info.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,12 +64,11 @@ components:
type: object
additionalProperties:
$ref: '#/components/schemas/NodeThreadPoolInfo'
# NOTE: total_indexing_buffer and total_indexing_buffer_in_bytes inverted according to the standard pattern, this is a bug: https://github.com/opensearch-project/OpenSearch/issues/16910
total_indexing_buffer:
description: Total heap allowed to be used to hold recently indexed documents before they must be written to disk. This size is a shared pool across all shards on this node, and is controlled by Indexing Buffer settings.
$ref: '_common.yaml#/components/schemas/ByteCount'
total_indexing_buffer_in_bytes:
$ref: '_common.yaml#/components/schemas/HumanReadableByteCount'
total_indexing_buffer_in_bytes:
$ref: '_common.yaml#/components/schemas/ByteCount'
transport:
$ref: '#/components/schemas/NodeInfoTransport'
transport_address:
Expand Down
Loading