Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding code guidelines #502

Merged

Conversation

martin-gaievski
Copy link
Member

Description

There are no code guidelines for the repo, this slows down new contributors and add cycles during code reviews.

Check List

  • All tests pass
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@martin-gaievski martin-gaievski added backport 2.x Label will add auto workflow to backport PR to 2.x branch Maintenance Add support for new versions of OpenSearch/Dashboards from upstream labels Dec 2, 2023
Copy link

codecov bot commented Dec 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.69%. Comparing base (628cb64) to head (609bfe5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #502      +/-   ##
============================================
- Coverage     81.74%   81.69%   -0.06%     
+ Complexity     2511     2510       -1     
============================================
  Files           190      190              
  Lines          8564     8564              
  Branches       1436     1436              
============================================
- Hits           7001     6996       -5     
- Misses         1006     1014       +8     
+ Partials        557      554       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmazanec15
Copy link
Member

@martin-gaievski Can we update table of contents on dev guide as well?

@yuye-aws
Copy link
Member

yuye-aws commented Oct 2, 2024

Hi @martin-gaievski ! Are you still taking care of this PR? Why this is still draft?

@martin-gaievski
Copy link
Member Author

@yuye-aws resumed work on this PR, feel free to leave comments

@vibrantvarun
Copy link
Member

@martin-gaievski Can we resurrect this PR ?

@martin-gaievski
Copy link
Member Author

@martin-gaievski Can we resurrect this PR ?

yup, we can for sure, rebased it on latest main

@martin-gaievski
Copy link
Member Author

BWC are failing, looks like ml-commons related problem:

https://github.com/opensearch-project/neural-search/actions/runs/12998883054/job/36253263991?pr=502#step:4:409

    org.opensearch.client.ResponseException: method [POST], host [http://[::1]:39469], URI [/neuralsearch-bwc-testsparseencodingprocessor_e2eflow/_doc/1?refresh=true], status line [HTTP/1.1 500 Internal Server Error]
    {"error":{"root_cause":[{"type":"null_pointer_exception","reason":"Cannot invoke \"org.opensearch.ml.common.output.model.ModelTensorOutput.getMlModelOutputs()\" because \"modelTensorOutput\" is null"}],"type":"null_pointer_exception","reason":"Cannot invoke \"org.opensearch.ml.common.output.model.ModelTensorOutput.getMlModelOutputs()\" because \"modelTensorOutput\" is null"},"status":500}

Signed-off-by: Martin Gaievski <gaievski@amazon.com>
Signed-off-by: Martin Gaievski <gaievski@amazon.com>
Signed-off-by: Martin Gaievski <gaievski@amazon.com>
Copy link
Member

@vibrantvarun vibrantvarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@martin-gaievski martin-gaievski removed the backport 2.x Label will add auto workflow to backport PR to 2.x branch label Feb 21, 2025
@heemin32 heemin32 merged commit 9cc8959 into opensearch-project:main Feb 21, 2025
53 checks passed
will-hwang pushed a commit to will-hwang/neural-search that referenced this pull request Feb 24, 2025
* Adding code guidelines to DEVELOPER_GUIDE md

Signed-off-by: Martin Gaievski <gaievski@amazon.com>

* Adding guidelines to the table of content

Signed-off-by: Martin Gaievski <gaievski@amazon.com>

* Added section with spotlessApply and javadoc commands

Signed-off-by: Martin Gaievski <gaievski@amazon.com>

---------

Signed-off-by: Martin Gaievski <gaievski@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Add support for new versions of OpenSearch/Dashboards from upstream skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants