-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding code guidelines #502
Adding code guidelines #502
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #502 +/- ##
============================================
- Coverage 81.74% 81.69% -0.06%
+ Complexity 2511 2510 -1
============================================
Files 190 190
Lines 8564 8564
Branches 1436 1436
============================================
- Hits 7001 6996 -5
- Misses 1006 1014 +8
+ Partials 557 554 -3 ☔ View full report in Codecov by Sentry. |
@martin-gaievski Can we update table of contents on dev guide as well? |
Hi @martin-gaievski ! Are you still taking care of this PR? Why this is still draft? |
ff18ce6
to
d693b58
Compare
@yuye-aws resumed work on this PR, feel free to leave comments |
509cb24
to
71d31e6
Compare
@martin-gaievski Can we resurrect this PR ? |
71d31e6
to
eccf8b1
Compare
yup, we can for sure, rebased it on latest main |
BWC are failing, looks like ml-commons related problem:
|
Signed-off-by: Martin Gaievski <gaievski@amazon.com>
Signed-off-by: Martin Gaievski <gaievski@amazon.com>
eccf8b1
to
14ff4f4
Compare
Signed-off-by: Martin Gaievski <gaievski@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks
* Adding code guidelines to DEVELOPER_GUIDE md Signed-off-by: Martin Gaievski <gaievski@amazon.com> * Adding guidelines to the table of content Signed-off-by: Martin Gaievski <gaievski@amazon.com> * Added section with spotlessApply and javadoc commands Signed-off-by: Martin Gaievski <gaievski@amazon.com> --------- Signed-off-by: Martin Gaievski <gaievski@amazon.com>
Description
There are no code guidelines for the repo, this slows down new contributors and add cycles during code reviews.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.