Add filter function for NeuralQueryBuilder and HybridQueryBuilder and… #1206
+418
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… modify fromXContent function in HybridQueryBuilder to support filter field. Signed-off-by: Chloe Gao <chloewq@amazon.com>
chloewqg
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
sean-zheng-amazon,
model-collapse,
zane-neo,
vibrantvarun,
zhichao-aws,
yuye-aws and
minalsha
as code owners
junqiu-lei
reviewed
Mar 3, 2025
| @@ -94,6 +95,31 @@ public HybridQueryBuilder add(QueryBuilder queryBuilder) { | |||
| return this; | |||
| } | |||
|
|
|||
| /** | |||
| * Function to support filter function on HybridQueryBuilder filter. Currently pushing down a filter | |||
There was a problem hiding this comment.
Suggested change
| * Function to support filter function on HybridQueryBuilder filter. Currently pushing down a filter | |
| * Function to support filter on HybridQueryBuilder filter. Currently pushing down a filter |
| * @return return itself with underlying filter combined with passed in filter | ||
| */ | ||
| public QueryBuilder filter(QueryBuilder filterToBeAdded) { | ||
| if (validateFilterParams(filterToBeAdded) == false) { |
There was a problem hiding this comment.
the method validateFilterParams is missed i think.
heemin32
reviewed
Mar 3, 2025
| if (!validateFilterParams(filter)) { | ||
| return this; | ||
| } | ||
| HybridQueryBuilder compoundQueryBuilder = new HybridQueryBuilder(); |
There was a problem hiding this comment.
Why do we have to create a new query builder instead of returning this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… modify fromXContent function in HybridQueryBuilder to support filter field.
Description
Add filter function to NeuralQueryBuilder and HybridQueryBuilder, which allows to push down non null filter. One exception is that when HybridQueryBuilder has a nested HybridQueryBuilder, then calling the filter function will cause UnsupportedOperationException
Related Issues
Resolves #1206
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.