code refactoring on MLCommonsClientAccessor request #1178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
Enhancements
will-hwang
reviewed
Feb 7, 2025
src/test/java/org/opensearch/neuralsearch/processor/InferenceProcessorTests.java
Show resolved
Hide resolved
will-hwang
reviewed
Feb 7, 2025
src/test/java/org/opensearch/neuralsearch/ml/MLCommonsClientAccessorTests.java
Outdated
Show resolved
Hide resolved
heemin32
reviewed
Feb 7, 2025
src/main/java/org/opensearch/neuralsearch/ml/MLCommonsClientAccessor.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/neuralsearch/ml/MLCommonsClientAccessor.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/neuralsearch/ml/MLCommonsClientAccessor.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/neuralsearch/ml/MLCommonsClientAccessor.java
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1178 +/- ##
============================================
- Coverage 81.72% 81.59% -0.13%
+ Complexity 2494 1245 -1249
============================================
Files 186 93 -93
Lines 8426 4217 -4209
Branches 1428 714 -714
============================================
- Hits 6886 3441 -3445
+ Misses 1000 507 -493
+ Partials 540 269 -271 ☔ View full report in Codecov by Sentry. |
added 3 commits
February 11, 2025 18:10
Signed-off-by: Fen Qin <mfenqin@amazon.com>
Signed-off-by: Fen Qin <mfenqin@amazon.com>
Signed-off-by: Fen Qin <mfenqin@amazon.com>
fen-qin
force-pushed
the
ml-accessor-request
branch
from
c2179c3 to
bd53055
Compare
fen-qin
requested review from
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
sean-zheng-amazon,
model-collapse,
zane-neo,
vibrantvarun,
zhichao-aws and
yuye-aws
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a code refactoring on encapsulation of MLCommonsClientAccessor required parameters into a POJO object.
Related Issues
Resolves #790
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.