[Backport 2.12] Fixes password assignment for integTest when using remote cluster (#1091) #1094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DarshitChanpura
requested review from
bowenlan-amzn,
getsaurabh02,
lezzago,
praveensameneni,
xluo-aws,
gaobinlong,
Hailong-am,
amsiglan,
sbcd90,
eirsep and
AWSHurneyt
as code owners
1 task
DarshitChanpura
changed the title
…ensearch-project#1091) (cherry picked from commit 027509e) Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
DarshitChanpura
force-pushed
the
backport/backport-1091-to-2.12
branch
from
3e899e9 to
f68d3aa
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.12 #1094 +/- ##
============================================
- Coverage 75.13% 75.08% -0.05%
+ Complexity 2908 2904 -4
============================================
Files 372 372
Lines 17122 17122
Branches 2474 2474
============================================
- Hits 12864 12856 -8
- Misses 2887 2899 +12
+ Partials 1371 1367 -4 ☔ View full report in Codecov by Sentry. |
r1walz
approved these changes
Feb 7, 2024
bowenlan-amzn
approved these changes
Feb 8, 2024
|
@r1walz @bowenlan-amzn not sure if CI checks need to be successful for merging this but, can you re-run failed checks. Seems like a connection issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #1091
(cherry picked from commit 027509e)
CheckList:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.