Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing bug in transform API validation to support index patterns #1237

Merged
merged 5 commits into from
Jan 19, 2025
Merged

Fixing bug in transform API validation to support index patterns #1237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bc26f9f
Fixing bug in transform API validation
tandonks Dec 26, 2024
f499500
Adding test for creating transform job using wildcard
tandonks Jan 18, 2025
fa33bd5
Retracting a change which was for testing only
tandonks Jan 18, 2025
c6c1d0c
Fixing an issue with the delete test of transform
tandonks Jan 18, 2025
3fd38ba
Modifying transform test
tandonks Jan 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
110 changes: 95 additions & 15 deletions cypress/integration/plugins/index-management-dashboards-plugin/transforms_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { BASE_PATH, IM_PLUGIN_NAME } from "../../../utils/constants";
import sampleTransform from "../../../fixtures/plugins/index-management-dashboards-plugin/sample_transform";

const TRANSFORM_ID = "test_transform_id";

const TRANSFORM_ID_WILDCARD = "test_transform_wildard";
describe("Transforms", () => {
before(() => {
// Delete all indices
Expand Down Expand Up @@ -50,7 +50,7 @@ describe("Transforms", () => {
cy.contains("Create transform", { timeout: 60000 });
});

describe("can be created", () => {
describe("can be created with source index", () => {
it("successfully", () => {
// Confirm we loaded empty state
cy.contains("Transform jobs help you create a materialized view on top of existing data.");
Expand Down Expand Up @@ -128,6 +128,96 @@ describe("Transforms", () => {
});
});

describe("can be created with source index wildcard", () => {
it("successfully", () => {
// Confirm we loaded empty state
// cy.contains("Transform jobs help you create a materialized view on top of existing data.");

// Route to create transform page
cy.contains("Create transform").click({ force: true });

// Type in transform ID
cy.get(`input[placeholder="my-transformjob1"]`).type(TRANSFORM_ID_WILDCARD, {
force: true,
});

// Get description input box
cy.get(`textarea[data-test-subj="description"]`).focus().type("some description");

// Enter source index
cy.get(`div[data-test-subj="sourceIndexCombobox"]`)
.find(`input[data-test-subj="comboBoxSearchInput"]`)
.focus()
.type("opensearch_dashboards_sample_data_ecommerce*{enter}");

cy.wait(5000);

// Enter target index
cy.get(`div[data-test-subj="targetIndexCombobox"]`)
.find(`input[data-test-subj="comboBoxSearchInput"]`)
.focus()
.type("test_transform{enter}");

cy.wait(2000);

// Click the next button
cy.get("button").contains("Next").click({ force: true });

// Confirm that we got to step 2 of creation page
cy.contains("Select fields to transform");

cy.get(`button[data-test-subj="category.keywordOptionsPopover"]`).click({
force: true,
});

cy.contains("Group by terms").click({ force: true });

// Confirm group was added
cy.contains("category.keyword_terms");

// Add aggregable field
cy.contains("50 columns hidden").click({ force: true });
cy.contains("taxless_total_price").click({ force: true });
// Click out of the window
cy.contains("Select fields to transform").click({ force: true });

cy.get(`button[data-test-subj="taxless_total_priceOptionsPopover"]`).click({ force: true });

cy.contains("Aggregate by avg").click({ force: true });

// Confirm agg was added
cy.contains("avg_taxless_total_price");

// Click the next button
cy.get("button").contains("Next").click({ force: true });

// Confirm that we got to step 3 of creation page
cy.contains("Job enabled by default");

// Click the next button
cy.get("button").contains("Next").click({ force: true });

// Confirm that we got to step 4 of creation page
cy.contains("Review and create");

// Click the create button
cy.get("button").contains("Create").click({ force: true });

cy.wait(2000);

// Verify that sample data is add by checking toast notification
cy.contains(`Transform job "${TRANSFORM_ID_WILDCARD}" successfully created.`);
cy.location("hash").should("contain", "transforms");
cy.get(`button[data-test-subj="transformLink_${TRANSFORM_ID_WILDCARD}"]`);

cy.request({
method: "DELETE",
url: `${Cypress.env("openSearchUrl")}/_plugins/_transform/${TRANSFORM_ID_WILDCARD} `,
failOnStatusCode: false,
});
});
});

describe("can be edited", () => {
beforeEach(() => {
cy.createTransform(TRANSFORM_ID, sampleTransform);
Expand Down Expand Up @@ -208,9 +298,6 @@ describe("Transforms", () => {

// Confirm we got deleted toaster
cy.contains(`"${TRANSFORM_ID}" successfully deleted`);

// Confirm showing empty loading state
cy.contains("Transform jobs help you create a materialized view on top of existing data.");
});
});

Expand All @@ -226,10 +313,7 @@ describe("Transforms", () => {

// Intercept different transform requests endpoints to wait before clicking disable and enable buttons
cy.intercept(`/api/ism/transforms/${TRANSFORM_ID}`).as("getTransform");
cy.intercept(`/api/ism/transforms/${TRANSFORM_ID}/_stop`).as(
"stopTransform"
);

cy.intercept(`/api/ism/transforms/${TRANSFORM_ID}/_stop`).as("stopTransform");

// Click into transform job details page
cy.get(`[data-test-subj="transformLink_${TRANSFORM_ID}"]`).click({
Expand All @@ -248,9 +332,7 @@ describe("Transforms", () => {
cy.get(`[data-test-subj="actionButton"]`).click({ force: true });

// Click Disable button
cy.get(`[data-test-subj="disableButton"]`)
.should("not.be.disabled")
.click();
cy.get(`[data-test-subj="disableButton"]`).should("not.be.disabled").click();

cy.wait("@stopTransform");
cy.wait("@getTransform");
Expand All @@ -265,9 +347,7 @@ describe("Transforms", () => {
cy.get(`[data-test-subj="actionButton"]`).click({ force: true });

// Click Enable button
cy.get(`[data-test-subj="enableButton"]`)
.should("not.be.disabled")
.click({ force: true });
cy.get(`[data-test-subj="enableButton"]`).should("not.be.disabled").click({ force: true });

// Confirm we get toaster saying transform job is enabled
cy.contains(`"${TRANSFORM_ID}" is enabled`);
Expand Down
4 changes: 2 additions & 2 deletions server/routes/transforms.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ export default function (services: NodeServices, router: IRouter, dataSourceEnab
params: schema.object({
index: schema.string({
validate: (value) => {
const invalidCharactersPattern = /[\s,:\"*+\/\\|?#><]/;
const invalidCharactersPattern = /[\s,:\"+\/\\|?#><]/;
if (value !== value.toLowerCase() || value.startsWith("_") || value.startsWith("-") || invalidCharactersPattern.test(value)) {
return "Invalid index name.";
}
Expand Down Expand Up @@ -148,7 +148,7 @@ export default function (services: NodeServices, router: IRouter, dataSourceEnab
{
source_index: schema.string({
validate: (value) => {
const invalidCharactersPattern = /[\s,:\"*+\/\\|?#><]/;
const invalidCharactersPattern = /[\s,:\"+\/\\|?#><]/;
if (
value !== value.toLowerCase() ||
value.startsWith("_") ||
Expand Down
Loading