[Look & Feel] Consistency and Density Changes for Snapshot Management #1148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shey Gao <sheygao@amazon.com>
SheyGao
changed the title
SheyGao
requested review from
bowenlan-amzn,
Hailong-am,
RamakrishnaChilaka,
vikasvb90 and
SuZhou-Joe
as code owners
RamakrishnaChilaka
previously approved these changes
Aug 29, 2024
|
LGTM, retriggered cypress E2E tests. |
|
@SheyGao Could you please fix the unit test failure? |
Signed-off-by: Shey Gao <sheygao@amazon.com>
SuZhou-Joe
approved these changes
Sep 2, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 2, 2024
…#1148) * initial changes Signed-off-by: Shey Gao <sheygao@amazon.com> * fixed unit tests Signed-off-by: Shey Gao <sheygao@amazon.com> --------- Signed-off-by: Shey Gao <sheygao@amazon.com> Co-authored-by: Shey Gao <sheygao@amazon.com> Co-authored-by: Hailong Cui <ihailong@amazon.com> (cherry picked from commit a7d317a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Sep 2, 2024
…#1148) (#1159) * initial changes * fixed unit tests --------- (cherry picked from commit a7d317a) Signed-off-by: Shey Gao <sheygao@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Shey Gao <sheygao@amazon.com> Co-authored-by: Hailong Cui <ihailong@amazon.com>
astute-decipher
pushed a commit
to astute-decipher/index-management-dashboards-plugin
that referenced
this pull request
Sep 2, 2024
…opensearch-project#1148) * initial changes Signed-off-by: Shey Gao <sheygao@amazon.com> * fixed unit tests Signed-off-by: Shey Gao <sheygao@amazon.com> --------- Signed-off-by: Shey Gao <sheygao@amazon.com> Co-authored-by: Shey Gao <sheygao@amazon.com> Co-authored-by: Hailong Cui <ihailong@amazon.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Note that this PR only contains partial changes, and the other changes are made in #1157
This PR makes consistency and density improvements, including:
Screenshots
Standard Paragraph Text Size
Semantic Headers
Plus Icon and PlusInCircle Icon
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.