update newHeader for component template pages #1122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 17, 2024 20:06
Signed-off-by: Shubh Sahu <shubhvs@amazon.com>
Signed-off-by: Shubh Sahu <shubhvs@amazon.com>
Signed-off-by: Shubh Sahu <shubhvs@amazon.com>
astute-decipher
requested review from
amsiglan,
AWSHurneyt,
bowenlan-amzn,
getsaurabh02,
praveensameneni,
xluo-aws,
gaobinlong,
Hailong-am,
SuZhou-Joe,
lezzago,
sbcd90,
eirsep,
r1walz and
vikasvb90
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1122 +/- ##
==========================================
- Coverage 63.43% 61.71% -1.73%
==========================================
Files 344 345 +1
Lines 11668 12408 +740
Branches 2260 2481 +221
==========================================
+ Hits 7402 7658 +256
- Misses 3689 4071 +382
- Partials 577 679 +102 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Shubh Sahu <shubhvs@amazon.com>
SuZhou-Joe
approved these changes
Aug 19, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 19, 2024
* first commit for Component template Signed-off-by: Shubh Sahu <shubhvs@amazon.com> * fixing uts Signed-off-by: Shubh Sahu <shubhvs@amazon.com> * corrected 1 ut Signed-off-by: Shubh Sahu <shubhvs@amazon.com> * Look good changes Signed-off-by: Shubh Sahu <shubhvs@amazon.com> --------- Signed-off-by: Shubh Sahu <shubhvs@amazon.com> Co-authored-by: Shubh Sahu <shubhvs@amazon.com> (cherry picked from commit c269c85) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Aug 19, 2024
* first commit for Component template * fixing uts * corrected 1 ut * Look good changes --------- (cherry picked from commit c269c85) Signed-off-by: Shubh Sahu <shubhvs@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Shubh Sahu <shubhvs@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the new header for component template pages
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.
component template pages (when
useNewHomePageis disabled) :List view :
Create view :
Detail view :
component template pages (when
useNewHomePageis enabled) :List view :
Create view :
Detail view :
