Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update newHeader for Index state management policies #1108

Merged
merged 9 commits into from
Aug 17, 2024
Merged

update newHeader for Index state management policies #1108

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d0b8d86
Initial commit for header update for snapshot management policy page
Aug 14, 2024
ad0b9ac
Merge branch 'opensearch-project:main' into myismplugin
astute-decipher Aug 15, 2024
2cee96a
some correction
Aug 15, 2024
a8d92b0
final commit
Aug 15, 2024
37ba281
Update pages snapshots (#1111)
skumawat2025 Aug 16, 2024
22f86aa
Fix for snapshot test race condition (#1113)
CaptainDredge Aug 16, 2024
12e38b6
Few refactoring
Aug 16, 2024
b4cfed3
Merge branch 'opensearch-project:main' into myismplugin
astute-decipher Aug 16, 2024
eb62eab
resolving UT build failures
Aug 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 28 additions & 14 deletions public/pages/CreatePolicy/containers/CreatePolicy/CreatePolicy.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import { getErrorMessage } from "../../../../utils/helpers";
import { CoreServicesContext } from "../../../../components/core_services";
import { DataSourceMenuContext, DataSourceMenuProperties } from "../../../../services/DataSourceMenuContext";
import { useUpdateUrlWithDataSourceProperties } from "../../../../components/MDSEnabledComponent";
import { getUISettings } from "../../../../services/Services";

interface CreatePolicyProps extends RouteComponentProps, DataSourceMenuProperties {
isEdit: boolean;
Expand All @@ -32,13 +33,16 @@ interface CreatePolicyState {
submitError: string;
isSubmitting: boolean;
hasSubmitted: boolean;
useNewUX: boolean;
}

export class CreatePolicy extends Component<CreatePolicyProps, CreatePolicyState> {
static contextType = CoreServicesContext;
_isMount: boolean;
constructor(props: CreatePolicyProps) {
super(props);
const uiSettings = getUISettings();
const useNewUx = uiSettings.get("home:useNewHomePage");

this.state = {
policySeqNo: null,
Expand All @@ -49,29 +53,32 @@ export class CreatePolicy extends Component<CreatePolicyProps, CreatePolicyState
jsonString: "",
isSubmitting: false,
hasSubmitted: false,
useNewUX: useNewUx,
};

this._isMount = true;
}

componentDidMount = async (): Promise<void> => {
this.context.chrome.setBreadcrumbs([BREADCRUMBS.INDEX_MANAGEMENT, BREADCRUMBS.INDEX_POLICIES]);
const breadCrumbs = this.state.useNewUX ? [BREADCRUMBS.INDEX_POLICIES_NEW] : [BREADCRUMBS.INDEX_MANAGEMENT, BREADCRUMBS.INDEX_POLICIES];
this.context.chrome.setBreadcrumbs(breadCrumbs);
if (this.props.isEdit) {
const { id } = queryString.parse(this.props.location.search);
if (typeof id === "string" && !!id) {
this.context.chrome.setBreadcrumbs([
BREADCRUMBS.INDEX_MANAGEMENT,
BREADCRUMBS.INDEX_POLICIES,
BREADCRUMBS.EDIT_POLICY,
{ text: id },
]);
const editBreadCrumbs = this.state.useNewUX
? [BREADCRUMBS.INDEX_POLICIES_NEW, { text: id }]
: [BREADCRUMBS.INDEX_MANAGEMENT, BREADCRUMBS.INDEX_POLICIES, BREADCRUMBS.EDIT_POLICY, { text: id }];
this.context.chrome.setBreadcrumbs(editBreadCrumbs);
await this.getPolicyToEdit(id);
} else {
this.context.notifications.toasts.addDanger(`Invalid policy id: ${id}`);
this.props.history.push(ROUTES.INDEX_POLICIES);
}
} else {
this.context.chrome.setBreadcrumbs([BREADCRUMBS.INDEX_MANAGEMENT, BREADCRUMBS.INDEX_POLICIES, BREADCRUMBS.CREATE_POLICY]);
const createBreadCrumbs = this.state.useNewUX
? [BREADCRUMBS.INDEX_POLICIES_NEW, BREADCRUMBS.CREATE_POLICY_NEW]
: [BREADCRUMBS.INDEX_MANAGEMENT, BREADCRUMBS.INDEX_POLICIES, BREADCRUMBS.CREATE_POLICY];
this.context.chrome.setBreadcrumbs(createBreadCrumbs);
this.setState({ jsonString: DEFAULT_POLICY });
}
};
Expand Down Expand Up @@ -224,7 +231,7 @@ export class CreatePolicy extends Component<CreatePolicyProps, CreatePolicyState

render() {
const { isEdit } = this.props;
const { policyId, policyIdError, jsonString, submitError, isSubmitting } = this.state;
const { policyId, policyIdError, jsonString, submitError, isSubmitting, useNewUX } = this.state;

let hasJSONError = false;
try {
Expand All @@ -233,12 +240,19 @@ export class CreatePolicy extends Component<CreatePolicyProps, CreatePolicyState
hasJSONError = true;
}

const padding_style = useNewUX ? { padding: "0px 0px" } : { padding: "25px 50px" };
return (
<div style={{ padding: "25px 50px" }}>
<EuiTitle size="l">
<h1>{isEdit ? "Edit" : "Create"} policy</h1>
</EuiTitle>
<EuiSpacer />
<div style={padding_style}>
{!useNewUX ? (
<>
<EuiTitle size="l">
<h1>{isEdit ? "Edit" : "Create"} policy</h1>
</EuiTitle>
<EuiSpacer />
</>
) : (
<></>
)}
{this.renderEditCallOut()}
<ConfigurePolicy policyId={policyId} policyIdError={policyIdError} isEdit={isEdit} onChange={this.onChange} />
<EuiSpacer />
Expand Down
Loading
Loading