Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update newHeader for Index state management policies #1108

Merged
merged 9 commits into from
Aug 17, 2024

Conversation

astute-decipher
Copy link
Contributor

@astute-decipher astute-decipher commented Aug 14, 2024

Description

This PR updates the new header for Index state management policies

Issues Resolved

[List any issues this PR will resolve]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Index state management policy pages (when useNewHomePage is disabled) :

Policy list view :
image

Policy details view :
image

Create view (In visual editor) :
image

Create view (in Json editor) :
image

Edit policy view (In visual editor) :
image

Edit policy view (in Json editor) :
image

Index state management policy pages (when useNewHomePage is enabled) :

Policy list view :
image

Policy details view :
image

Create view (In visual editor) :
image

Create view (in Json editor) :
image

Edit policy view (In visual editor) :
image

Edit policy view (in Json editor) :
image

Shubh Sahu and others added 4 commits August 14, 2024 15:28
Signed-off-by: Shubh Sahu <shubhvs@amazon.com>
Signed-off-by: Shubh Sahu <shubhvs@amazon.com>
Signed-off-by: Shubh Sahu <shubhvs@amazon.com>
@astute-decipher astute-decipher changed the title header update for snapshot management policy page update newHeader for snapshot IndexState management policies Aug 15, 2024
@astute-decipher astute-decipher changed the title update newHeader for snapshot IndexState management policies update newHeader for Index state management policies Aug 15, 2024
@astute-decipher astute-decipher marked this pull request as ready for review August 15, 2024 11:48
@astute-decipher astute-decipher self-assigned this Aug 15, 2024
SuZhou-Joe
SuZhou-Joe previously approved these changes Aug 15, 2024
@SuZhou-Joe
Copy link
Member

@astute-decipher Unit test failed, could you please fix that? You can ignore the snapshot part.

skumawat2025 and others added 3 commits August 16, 2024 13:46
Signed-off-by: Sandeep Kumawat <skumwt@amazon.com>
Co-authored-by: Sandeep Kumawat <skumwt@amazon.com>
Signed-off-by: Prabhat Sharma <ptsharma@amazon.com>
Co-authored-by: Prabhat Sharma <ptsharma@amazon.com>
Signed-off-by: Shubh Sahu <shubhvs@amazon.com>
Signed-off-by: Shubh Sahu <shubhvs@amazon.com>
@kgcreative
Copy link
Member

Small nit:

Edit policy view (In visual editor), and Edit Policy
Both of these views show truncated breadcrumbs. I think we have enough space now that we can show the full breadcrumb when we have the space.

@AMoo-Miki -> See this page as an outlier with long breadcrumbs
@xeniatup -> Let's consider this for mobile behavior as well

@SuZhou-Joe
Copy link
Member

The change is a little bit huge but mostly are template code if else to put the headers in new header or leave as is. I would rely on CI / screenshot / UX sign-off to help me verify the changes.

@SuZhou-Joe SuZhou-Joe merged commit 12f28d1 into opensearch-project:main Aug 17, 2024
8 of 11 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 17, 2024
* Initial commit for header update for snapshot management policy page

Signed-off-by: Shubh Sahu <shubhvs@amazon.com>

* some correction

Signed-off-by: Shubh Sahu <shubhvs@amazon.com>

* final commit

Signed-off-by: Shubh Sahu <shubhvs@amazon.com>

* Update pages snapshots (#1111)

Signed-off-by: Sandeep Kumawat <skumwt@amazon.com>
Co-authored-by: Sandeep Kumawat <skumwt@amazon.com>

* Fix for snapshot test race condition (#1113)

Signed-off-by: Prabhat Sharma <ptsharma@amazon.com>
Co-authored-by: Prabhat Sharma <ptsharma@amazon.com>

* Few refactoring

Signed-off-by: Shubh Sahu <shubhvs@amazon.com>

* resolving UT build failures

Signed-off-by: Shubh Sahu <shubhvs@amazon.com>

---------

Signed-off-by: Shubh Sahu <shubhvs@amazon.com>
Signed-off-by: Sandeep Kumawat <skumwt@amazon.com>
Signed-off-by: Prabhat Sharma <ptsharma@amazon.com>
Co-authored-by: Shubh Sahu <shubhvs@amazon.com>
Co-authored-by: Sandeep Kumawat <2025sandeepkumawat@gmail.com>
Co-authored-by: Sandeep Kumawat <skumwt@amazon.com>
Co-authored-by: Prabhat <20185657+CaptainDredge@users.noreply.github.com>
Co-authored-by: Prabhat Sharma <ptsharma@amazon.com>
(cherry picked from commit 12f28d1)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
astute-decipher added a commit to astute-decipher/index-management-dashboards-plugin that referenced this pull request Aug 17, 2024
…ect#1108)

* Initial commit for header update for snapshot management policy page

Signed-off-by: Shubh Sahu <shubhvs@amazon.com>

* some correction

Signed-off-by: Shubh Sahu <shubhvs@amazon.com>

* final commit

Signed-off-by: Shubh Sahu <shubhvs@amazon.com>

* Update pages snapshots (opensearch-project#1111)

Signed-off-by: Sandeep Kumawat <skumwt@amazon.com>
Co-authored-by: Sandeep Kumawat <skumwt@amazon.com>

* Fix for snapshot test race condition (opensearch-project#1113)

Signed-off-by: Prabhat Sharma <ptsharma@amazon.com>
Co-authored-by: Prabhat Sharma <ptsharma@amazon.com>

* Few refactoring

Signed-off-by: Shubh Sahu <shubhvs@amazon.com>

* resolving UT build failures

Signed-off-by: Shubh Sahu <shubhvs@amazon.com>

---------

Signed-off-by: Shubh Sahu <shubhvs@amazon.com>
Signed-off-by: Sandeep Kumawat <skumwt@amazon.com>
Signed-off-by: Prabhat Sharma <ptsharma@amazon.com>
Co-authored-by: Shubh Sahu <shubhvs@amazon.com>
Co-authored-by: Sandeep Kumawat <2025sandeepkumawat@gmail.com>
Co-authored-by: Sandeep Kumawat <skumwt@amazon.com>
Co-authored-by: Prabhat <20185657+CaptainDredge@users.noreply.github.com>
Co-authored-by: Prabhat Sharma <ptsharma@amazon.com>
SuZhou-Joe pushed a commit that referenced this pull request Aug 19, 2024
* Initial commit for header update for snapshot management policy page

Signed-off-by: Shubh Sahu <shubhvs@amazon.com>

* some correction

Signed-off-by: Shubh Sahu <shubhvs@amazon.com>

* final commit

Signed-off-by: Shubh Sahu <shubhvs@amazon.com>

* Update pages snapshots (#1111)

Signed-off-by: Sandeep Kumawat <skumwt@amazon.com>
Co-authored-by: Sandeep Kumawat <skumwt@amazon.com>

* Fix for snapshot test race condition (#1113)

Signed-off-by: Prabhat Sharma <ptsharma@amazon.com>
Co-authored-by: Prabhat Sharma <ptsharma@amazon.com>

* Few refactoring

Signed-off-by: Shubh Sahu <shubhvs@amazon.com>

* resolving UT build failures

Signed-off-by: Shubh Sahu <shubhvs@amazon.com>

---------

Signed-off-by: Shubh Sahu <shubhvs@amazon.com>
Signed-off-by: Sandeep Kumawat <skumwt@amazon.com>
Signed-off-by: Prabhat Sharma <ptsharma@amazon.com>
Co-authored-by: Shubh Sahu <shubhvs@amazon.com>
Co-authored-by: Sandeep Kumawat <2025sandeepkumawat@gmail.com>
Co-authored-by: Sandeep Kumawat <skumwt@amazon.com>
Co-authored-by: Prabhat <20185657+CaptainDredge@users.noreply.github.com>
Co-authored-by: Prabhat Sharma <ptsharma@amazon.com>
(cherry picked from commit 12f28d1)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe pushed a commit that referenced this pull request Aug 19, 2024
* Initial commit for header update for snapshot management policy page



* some correction



* final commit



* Update pages snapshots (#1111)




* Fix for snapshot test race condition (#1113)




* Few refactoring



* resolving UT build failures



---------









(cherry picked from commit 12f28d1)

Signed-off-by: Shubh Sahu <shubhvs@amazon.com>
Signed-off-by: Sandeep Kumawat <skumwt@amazon.com>
Signed-off-by: Prabhat Sharma <ptsharma@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Shubh Sahu <shubhvs@amazon.com>
Co-authored-by: Sandeep Kumawat <2025sandeepkumawat@gmail.com>
Co-authored-by: Sandeep Kumawat <skumwt@amazon.com>
Co-authored-by: Prabhat <20185657+CaptainDredge@users.noreply.github.com>
Co-authored-by: Prabhat Sharma <ptsharma@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants