Use smaller and compressed varients of buttons and form components #1103

AMoo-Miki · 2024-08-02T21:51:41Z

Description

Replace instances of EuiButton that don't have an explicit sizing attribute to EuiSmallButton*.
Replace instances of Eui<form elements> that don't have density attributes to EuiCompressed<form elements>.

Check List

Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

SuZhou-Joe · 2024-08-20T08:52:33Z

https://github.com/opensearch-project/index-management-dashboards-plugin/blob/main/cypress/integration/plugins/index-management-dashboards-plugin/aliases.js#L88

There are some places that the Cypress test is consuming the class name to do assertion, and change the component is breaking the test cases.

Signed-off-by: Miki <miki@amazon.com>

AMoo-Miki · 2024-08-20T16:04:57Z

I have resolved conflicts. Please prioritize reviewing and merging this PR.

skumawat2025 · 2024-08-20T17:24:28Z

public/pages/CreateSnapshotPolicy/containers/CreateSnapshotPolicy/CreateSnapshotPolicy.tsx

  EuiAccordion,
-  EuiRadioGroup,
+  EuiCompressedRadioGroup,


EuiCompressedRadioGroup has been imported twice. Can we please remove this.

skumawat2025 · 2024-08-20T17:25:40Z

public/pages/SnapshotPolicies/containers/SnapshotPolicies/SnapshotPolicies.tsx

@@ -12,7 +12,7 @@ import {
  Criteria,
  Direction,
  EuiBasicTable,
-  EuiButton,
+  EuiSmallButton,


EuiSmallButton has been imported twice. Can we please remove this.

Signed-off-by: Miki <miki@amazon.com>

codecov · 2024-08-20T18:11:30Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.41%. Comparing base (a53ff41) to head (503e37b).
Report is 3 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1103      +/-   ##
==========================================
- Coverage   61.61%   61.41%   -0.21%     
==========================================
  Files         345      345              
  Lines       12449    12656     +207     
  Branches     2509     2556      +47     
==========================================
+ Hits         7671     7773     +102     
- Misses       4075     4148      +73     
- Partials      703      735      +32

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

SuZhou-Joe · 2024-08-21T08:33:34Z

Changed the Cypress test case a little bit to make it pass in this PR.

…1103) * Use EuiSmallButton Signed-off-by: Miki <miki@amazon.com> * Use EuiSmallButtonIcon Signed-off-by: Miki <miki@amazon.com> * Use EuiSmallButtonEmpty Signed-off-by: Miki <miki@amazon.com> * Use EuiCompressedFormRow Signed-off-by: Miki <miki@amazon.com> * Use EuiCompressedField* Signed-off-by: Miki <miki@amazon.com> * Use EuiCompressedSelect and EuiCompressedSuperSelect Signed-off-by: Miki <miki@amazon.com> * Use EuiCompressedCheckbox and EuiCompressedCheckboxGroup Signed-off-by: Miki <miki@amazon.com> * Use EuiCompressedRadio and EuiCompressedRadioGroup Signed-off-by: Miki <miki@amazon.com> * Use EuiCompressedSwitch Signed-off-by: Miki <miki@amazon.com> * Use EuiCompressedEuiTextArea Signed-off-by: Miki <miki@amazon.com> * Use EuiCompressedComboBox Signed-off-by: Miki <miki@amazon.com> * Use EuiSmallFilterButton Signed-off-by: Miki <miki@amazon.com> * Use EuiCompressedSuperDatePicker Signed-off-by: Miki <miki@amazon.com> * Update snapshots Signed-off-by: Miki <miki@amazon.com> * Fix bad `useNewUX` applications Signed-off-by: Miki <miki@amazon.com> * Fix tests Signed-off-by: Miki <miki@amazon.com> * Update tests and snapshots post-conflict resolution Signed-off-by: Miki <miki@amazon.com> * fix: e2e test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: Miki <miki@amazon.com> Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Co-authored-by: SuZhou-Joe <suzhou@amazon.com> (cherry picked from commit 7077166) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

…1103) (#1140) * Use EuiSmallButton * Use EuiSmallButtonIcon * Use EuiSmallButtonEmpty * Use EuiCompressedFormRow * Use EuiCompressedField* * Use EuiCompressedSelect and EuiCompressedSuperSelect * Use EuiCompressedCheckbox and EuiCompressedCheckboxGroup * Use EuiCompressedRadio and EuiCompressedRadioGroup * Use EuiCompressedSwitch * Use EuiCompressedEuiTextArea * Use EuiCompressedComboBox * Use EuiSmallFilterButton * Use EuiCompressedSuperDatePicker * Update snapshots * Fix bad `useNewUX` applications * Fix tests * Update tests and snapshots post-conflict resolution * fix: e2e test --------- (cherry picked from commit 7077166) Signed-off-by: Miki <miki@amazon.com> Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: SuZhou-Joe <suzhou@amazon.com>

AMoo-Miki requested review from amsiglan, AWSHurneyt, bowenlan-amzn, getsaurabh02, praveensameneni, xluo-aws, gaobinlong, Hailong-am, SuZhou-Joe, lezzago, sbcd90, eirsep, r1walz and vikasvb90 as code owners August 2, 2024 21:51

AMoo-Miki force-pushed the lnf-demo-2 branch from cc8a139 to 511c4fc Compare August 17, 2024 00:28

AWSHurneyt added backport 2.x v2.17.0 labels Aug 17, 2024

AMoo-Miki force-pushed the lnf-demo-2 branch 2 times, most recently from 7596c81 to 333af07 Compare August 19, 2024 16:03

skumawat2025 mentioned this pull request Aug 20, 2024

Incorporate feel and look good guide changes for snapshots pages, datastreams, rollups and notification settings #1132

Merged

1 task

AMoo-Miki added 9 commits August 20, 2024 08:34

Use EuiSmallButton

a735ae0

Signed-off-by: Miki <miki@amazon.com>

Use EuiSmallButtonIcon

ee01938

Signed-off-by: Miki <miki@amazon.com>

Use EuiSmallButtonEmpty

1feed02

Signed-off-by: Miki <miki@amazon.com>

Use EuiCompressedFormRow

e87ff2b

Signed-off-by: Miki <miki@amazon.com>

Use EuiCompressedField*

cad5c58

Signed-off-by: Miki <miki@amazon.com>

Use EuiCompressedSelect and EuiCompressedSuperSelect

202801e

Signed-off-by: Miki <miki@amazon.com>

Use EuiCompressedCheckbox and EuiCompressedCheckboxGroup

ab82860

Signed-off-by: Miki <miki@amazon.com>

Use EuiCompressedRadio and EuiCompressedRadioGroup

676e3eb

Signed-off-by: Miki <miki@amazon.com>

Use EuiCompressedSwitch

deed357

Signed-off-by: Miki <miki@amazon.com>

AMoo-Miki added 7 commits August 20, 2024 08:43

Use EuiCompressedEuiTextArea

e7447d0

Signed-off-by: Miki <miki@amazon.com>

Use EuiCompressedComboBox

5fa9add

Signed-off-by: Miki <miki@amazon.com>

Use EuiSmallFilterButton

29ddde8

Signed-off-by: Miki <miki@amazon.com>

Use EuiCompressedSuperDatePicker

5b5f090

Signed-off-by: Miki <miki@amazon.com>

Update snapshots

2c67345

Signed-off-by: Miki <miki@amazon.com>

Fix bad useNewUX applications

2324950

Signed-off-by: Miki <miki@amazon.com>

Fix tests

d1440a0

Signed-off-by: Miki <miki@amazon.com>

AMoo-Miki force-pushed the lnf-demo-2 branch from 6603205 to 4c31f6f Compare August 20, 2024 16:04

skumawat2025 reviewed Aug 20, 2024

View reviewed changes

AMoo-Miki force-pushed the lnf-demo-2 branch from 4c31f6f to aee6ada Compare August 20, 2024 17:57

Update tests and snapshots post-conflict resolution

95cc829

Signed-off-by: Miki <miki@amazon.com>

AMoo-Miki force-pushed the lnf-demo-2 branch from aee6ada to 95cc829 Compare August 20, 2024 17:58

fix: e2e test

503e37b

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

SuZhou-Joe force-pushed the lnf-demo-2 branch from 62c45b3 to 503e37b Compare August 21, 2024 05:58

SuZhou-Joe approved these changes Aug 21, 2024

View reviewed changes

SuZhou-Joe merged commit 7077166 into opensearch-project:main Aug 21, 2024
8 of 11 checks passed

opensearch-trigger-bot bot mentioned this pull request Aug 21, 2024

[Backport 2.x] Use smaller and compressed varients of buttons and form components #1140

Merged

skumawat2025 mentioned this pull request Aug 22, 2024

Replace EuiButton to EuiSmallButton in repositories page #1142

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use smaller and compressed varients of buttons and form components #1103

Use smaller and compressed varients of buttons and form components #1103

AMoo-Miki commented Aug 2, 2024

SuZhou-Joe commented Aug 20, 2024 •

edited

Loading

AMoo-Miki commented Aug 20, 2024

skumawat2025 Aug 20, 2024

skumawat2025 Aug 20, 2024 •

edited

Loading

codecov bot commented Aug 20, 2024 •

edited

Loading

SuZhou-Joe commented Aug 21, 2024

Use smaller and compressed varients of buttons and form components #1103

Use smaller and compressed varients of buttons and form components #1103

Conversation

AMoo-Miki commented Aug 2, 2024

Description

Check List

SuZhou-Joe commented Aug 20, 2024 • edited Loading

AMoo-Miki commented Aug 20, 2024

skumawat2025 Aug 20, 2024

Choose a reason for hiding this comment

skumawat2025 Aug 20, 2024 • edited Loading

Choose a reason for hiding this comment

codecov bot commented Aug 20, 2024 • edited Loading

Codecov Report

SuZhou-Joe commented Aug 21, 2024

SuZhou-Joe commented Aug 20, 2024 •

edited

Loading

skumawat2025 Aug 20, 2024 •

edited

Loading

codecov bot commented Aug 20, 2024 •

edited

Loading