Add MDS support to snapshot pages #1084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sandeep Kumawat <skumwt@amazon.com>
skumawat2025
force-pushed
the
mds-snapshots
branch
from
071a0f0 to
6e86690
Compare
skumawat2025
requested review from
amsiglan,
AWSHurneyt,
bowenlan-amzn,
getsaurabh02,
praveensameneni,
xluo-aws,
gaobinlong,
Hailong-am,
SuZhou-Joe,
lezzago,
sbcd90,
eirsep,
r1walz and
vikasvb90
as code owners
|
Hi @skumawat2025 , could you add screenshots for the different page or a video to show the integration? Thanks |
BionIT
approved these changes
Jul 12, 2024
SuZhou-Joe
approved these changes
Jul 13, 2024
|
@RamakrishnaChilaka could you help to take a look as well? |
RamakrishnaChilaka
approved these changes
Jul 15, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 15, 2024
Signed-off-by: Sandeep Kumawat <skumwt@amazon.com> Co-authored-by: Sandeep Kumawat <skumwt@amazon.com> (cherry picked from commit edf1e40) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Jul 16, 2024
Signed-off-by: Sandeep Kumawat <skumwt@amazon.com> Co-authored-by: Sandeep Kumawat <skumwt@amazon.com> (cherry picked from commit edf1e40) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Jul 16, 2024
(cherry picked from commit edf1e40) Signed-off-by: Sandeep Kumawat <skumwt@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Sandeep Kumawat <skumwt@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With this change we add MDS support to snapshot pages.
Issues Resolved
#1067
Video
Meeting+Recording+-+Kumawat.+Sandeep+Instant+Meeting.mp4
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.