Skip to content

Commit

Permalink
feat(data-prepper): add configurable threshold for liveness and readi…
Browse files Browse the repository at this point in the history
…ness probes

Signed-off-by: valere colleville <valere.colleville@gmail.com>
  • Loading branch information
vcolleville committed Feb 26, 2025
1 parent 0c3fbbf commit 339bd59
Show file tree
Hide file tree
Showing 4 changed files with 23 additions and 4 deletions.
5 changes: 5 additions & 0 deletions charts/data-prepper/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [0.3.2]
### Added
- Added configurable `livenessProbe.periodSeconds`,`livenessProbe.initialDelaySeconds`,`livenessProbe.failureThreshold`
- Added configurable `readinessProbe.periodSeconds`,`readinessProbe.initialDelaySeconds`,`readinessProbe.failureThreshold`

## [0.3.1]
### Added
- Added configurable `initContainers`
Expand Down
2 changes: 1 addition & 1 deletion charts/data-prepper/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.3.1
version: 0.3.2

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
Expand Down
9 changes: 6 additions & 3 deletions charts/data-prepper/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -62,16 +62,19 @@ spec:
{{- if not ( empty (.Values.config).ssl ) }}
scheme: HTTPS
{{- end }}
periodSeconds: 10
initialDelaySeconds: 2
failureThreshold: 2
periodSeconds: {{ .Values.livenessProbe.periodSeconds }}
initialDelaySeconds: {{ .Values.livenessProbe.initialDelaySeconds }}
failureThreshold: {{ .Values.livenessProbe.failureThreshold }}
readinessProbe:
httpGet:
path: /list
port: server
{{- if not ( empty (.Values.config).ssl ) }}
scheme: HTTPS
{{- end }}
periodSeconds: {{ .Values.readinessProbe.periodSeconds }}
initialDelaySeconds: {{ .Values.readinessProbe.initialDelaySeconds }}
failureThreshold: {{ .Values.readinessProbe.failureThreshold }}
resources:
{{- toYaml .Values.resources | nindent 12 }}
volumeMounts:
Expand Down
11 changes: 11 additions & 0 deletions charts/data-prepper/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,17 @@ initContainers: []
service:
type: ClusterIP

livenessProbe:
periodSeconds: 10
initialDelaySeconds: 2
failureThreshold: 2

#Default kubernetes value
readinessProbe:
periodSeconds: 10
initialDelaySeconds: 0
failureThreshold: 3

ingress:
enabled: false
className: ""
Expand Down

0 comments on commit 339bd59

Please sign in to comment.