Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LTR into available plugins documentation #9298

Merged
merged 3 commits into from
Feb 21, 2025

Conversation

rithin-pullela-aws
Copy link
Contributor

@rithin-pullela-aws rithin-pullela-aws commented Feb 20, 2025

Description

Remove the custom installation step in LTR since it is available out of the box.

Issues Resolved

Closes #[delete this text, including the brackets, and replace with the issue number]

Version

2.19 and further.

Frontend features

If you're submitting documentation for an OpenSearch Dashboards feature, add a video that shows how a user will interact with the UI step by step. A voiceover is optional.

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Remove the custom installation step in LTR since it is avialble out of the box

Signed-off-by: rithin-pullela-aws <rithinp@amazon.com>
Copy link

Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged.

Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer.

When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review.

@rithin-pullela-aws rithin-pullela-aws marked this pull request as draft February 20, 2025 22:28
Signed-off-by: rithin-pullela-aws <rithinp@amazon.com>
@rithin-pullela-aws rithin-pullela-aws marked this pull request as ready for review February 20, 2025 22:39
@rithin-pullela-aws
Copy link
Contributor Author

Need to backport to 2.19 as well. Thank you!

@ylwu-amzn
Copy link
Contributor

Version
List the OpenSearch version to which this PR applies, e.g. 2.14, 2.12--2.14, or all.

Change the version part in description ?

Copy link
Collaborator

@epugh epugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay!

@epugh
Copy link
Collaborator

epugh commented Feb 20, 2025

@JohannesDaniel would merging this change any other docs in the LTR plugin? Now that it ships with OpenSearch?

Copy link
Collaborator

@kolchfa-aws kolchfa-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @rithin-pullela-aws! Just one suggestion.

Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
Signed-off-by: Rithin Pullela <rithinp@amazon.com>
@kolchfa-aws
Copy link
Collaborator

@epugh @JohannesDaniel In the documentation, we are shifting to describe features rather than plugins. Of course, there are places that you need to mention that this feature resides in a plugin: for example, in installation instructions. But overall, if the plugin ships with OpenSearch, we don't need to mention it as a plugin.

@kolchfa-aws kolchfa-aws merged commit 9a74784 into opensearch-project:main Feb 21, 2025
5 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 21, 2025
* Add LTR into available plugins documentation

Remove the custom installation step in LTR since it is avialble out of the box

Signed-off-by: rithin-pullela-aws <rithinp@amazon.com>

* Remove copy bar at the bottom

Signed-off-by: rithin-pullela-aws <rithinp@amazon.com>

* Update _install-and-configure/plugins.md

Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
Signed-off-by: Rithin Pullela <rithinp@amazon.com>

---------

Signed-off-by: rithin-pullela-aws <rithinp@amazon.com>
Signed-off-by: Rithin Pullela <rithinp@amazon.com>
Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
(cherry picked from commit 9a74784)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants