Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing ISM permission #9222

Merged
merged 1 commit into from
Feb 17, 2025
Merged

Add missing ISM permission #9222

merged 1 commit into from
Feb 17, 2025

Conversation

Naarcha-AWS
Copy link
Collaborator

Issues Resolved

Closes #9218

Frontend features

If you're submitting documentation for an OpenSearch Dashboards feature, add a video that shows how a user will interact with the UI step by step. A voiceover is optional.

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
@Naarcha-AWS Naarcha-AWS added backport 1.3 PR: Backport label for v1.3.x 4 - Doc review PR: Doc review in progress backport 2.19 labels Feb 17, 2025
@Naarcha-AWS Naarcha-AWS self-assigned this Feb 17, 2025
Copy link

Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged.

Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer.

When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review.

Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Naarcha-AWS Naarcha-AWS merged commit cb0afde into main Feb 17, 2025
11 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 1.3 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-1.3 1.3
# Navigate to the new working tree
pushd ../.worktrees/backport-1.3
# Create a new branch
git switch --create backport/backport-9222-to-1.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 cb0afdedfcd215bda901455650a665d3254f928d
# Push it to GitHub
git push --set-upstream origin backport/backport-9222-to-1.3
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-1.3

Then, create a pull request where the base branch is 1.3 and the compare/head branch is backport/backport-9222-to-1.3.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.19 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.19 2.19
# Navigate to the new working tree
pushd ../.worktrees/backport-2.19
# Create a new branch
git switch --create backport/backport-9222-to-2.19
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 cb0afdedfcd215bda901455650a665d3254f928d
# Push it to GitHub
git push --set-upstream origin backport/backport-9222-to-2.19
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.19

Then, create a pull request where the base branch is 2.19 and the compare/head branch is backport/backport-9222-to-2.19.

@tronboto
Copy link

Thanks for picking this up so quickly but it doesn't look right to me. This is an indices permission so I believe it should be in this section: https://github.com/opensearch-project/documentation-website/blob/1791722391a8585b4664e306284cddef06bec8f2/_security/access-control/permissions.md#index-permissions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - Doc review PR: Doc review in progress backport 1.3 PR: Backport label for v1.3.x backport 2.19
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing documentation for ism index permission
3 participants