Fix index name in bitmap filtering docs #9032
Conversation
russcam
requested review from
kolchfa-aws,
Naarcha-AWS,
AMoo-Miki,
natebower,
dlvenable and
epugh
as code owners
|
Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged. Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer. When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review. |
There was a problem hiding this comment.
Thank you for making the docs better, @russcam! A small suggestion to keep the requests uniform.
|
@russcam Could you fix DCO so we can merge this PR? I just removed the extra lines between the code blocks and the includes. Thanks! |
|
@kolchfa-aws done |
|
Hey @russcam, looks like DCO is still failing, and you've picked up some extraneous commits. Could you please rebase and sign the commits that we want that are not signed? https://github.com/opensearch-project/documentation-website/pull/9032/checks?check_run_id=35404113474 Thanks so much! |
|
I can fix the issue that DCO has, but it requires me to sign commits that I haven't made (2604e82, ff96083). These extraneous commits are ones that have come in from the rebasing and merging that's been applied to the branch. I was in the process of addressing the review feedback, when GitHub was having issues, and these changes were made. A simple PR has been overcomplicated 🙂 |
Signed-off-by: Russ Cam <russ@searchpioneer.com> Signed-off-by: Russ Cam <russ.cam@forloop.co.uk>
Add forward slashes to URLs Signed-off-by: Russ Cam <russ@searchpioneer.com> Signed-off-by: Russ Cam <russ.cam@forloop.co.uk>
Signed-off-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> Signed-off-by: Russ Cam <russ.cam@forloop.co.uk>
|
I think this may require an interactive rebase. Otherwise, do you want to close this PR and just raise a new one with the changes: might be easier. |
|
@russcam Do you want to close this PR and open a new one with the changes? Might be easier 😄 |
|
@russcam I fixed the extra commits. Merging the PR now 😄 |
* Fix index name in bitmap filtering docs Signed-off-by: Russ Cam <russ@searchpioneer.com> Signed-off-by: Russ Cam <russ.cam@forloop.co.uk> * Apply changes from code review Add forward slashes to URLs Signed-off-by: Russ Cam <russ@searchpioneer.com> Signed-off-by: Russ Cam <russ.cam@forloop.co.uk> * Apply suggestions from code review Signed-off-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> Signed-off-by: Russ Cam <russ.cam@forloop.co.uk> --------- Signed-off-by: Russ Cam <russ@searchpioneer.com> Signed-off-by: Russ Cam <russ.cam@forloop.co.uk> Signed-off-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> Co-authored-by: Fanit Kolchina <kolchfa@amazon.com> (cherry picked from commit c2ba686) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
|
Thanks @kolchfa-aws 🙏 |
Description
Fix the name of the index used in some examples so that it is consistent with the surrounding documentation.
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.