Postgres schema name fix #5432
Merged
Postgres schema name fix #5432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oeyh
requested review from
sb2k16,
chenqi0805,
engechas,
san81,
srikanthjg,
graytaylor0,
dinujoh,
kkondaka,
KarstenSchnitter and
dlvenable
as code owners
divbok
reviewed
Feb 12, 2025
There was a problem hiding this comment.
I have made this change in my PR
There was a problem hiding this comment.
Can remove all the changes associated with this pattern in other files
There was a problem hiding this comment.
I need to add schemaName in this class.
There was a problem hiding this comment.
Merged your other PR. Will resolve the conflicts here.
Signed-off-by: Hai Yan <oeyh@amazon.com>
oeyh
force-pushed
the
rds/handle-postgres-schema-name
branch
from
3e4208a to
3fbd0ad
Compare
Signed-off-by: Hai Yan <oeyh@amazon.com>
divbok
approved these changes
Feb 12, 2025
Signed-off-by: Hai Yan <oeyh@amazon.com>
dinujoh
reviewed
Feb 13, 2025
| @@ -25,9 +27,12 @@ public class DataFileProgressState { | |||
| private String sourceDatabase; | |||
|
|
|||
| /** | |||
| * For MySQL, sourceTable is in the format of tableName | |||
| * For Postgres, sourceTable is in the format of schemaName.tableName | |||
| * For PostgreSQL engine type, schema is the schema name. | |||
There was a problem hiding this comment.
nit: sourceSchema is the schema name
| */ | ||
| @JsonProperty("sourceSchema") | ||
| private String sourceSchema; |
There was a problem hiding this comment.
How do plan to use this field for MySQL ?
There was a problem hiding this comment.
This field will not be used when the source is MySQL database.
| StreamProgressState progressState = streamPartition.getProgressState().get(); | ||
|
|
||
| return progressState.getPrimaryKeyMap().get(databaseName + "." + schemaName + "." + tableName); | ||
| } | ||
|
|
||
| private String getDatabaseName(List<String> tableNames) { | ||
| return tableNames.get(0).split("\\.")[0]; |
There was a problem hiding this comment.
nit: move the split delimiter to constant
Signed-off-by: Hai Yan <oeyh@amazon.com>
dinujoh
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Postgres tables are specified as
database.schema.table, while MySQL tables are specified asdatabase.table. This PR fixes an issue that the metadata in Postgres export and stream are not consistent.In summary, we use
databaseName,schemaNameandtableNameacross the rds source plugin.schemaNameis specific for Postgres, but for MySQL, we also fill this field with the same value asdatabaseName.Also refactors
TableMetadatato use builder pattern. A lot of its usages in test code were updated.Issues Resolved
Contributes to #5309
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.