migrate Blocking Buffer and StdInSource configurations off of plugin setting #5317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maxwell Brown <mxwelwbr@amazon.com>
2 tasks
Signed-off-by: Maxwell Brown <mxwelwbr@amazon.com>
Galactus22625
changed the title
…ugin-setting-for-configuration-classes
Signed-off-by: Maxwell Brown <mxwelwbr@amazon.com>
…ugin-setting-for-configuration-classes
Signed-off-by: Maxwell Brown <mxwelwbr@amazon.com>
Signed-off-by: Maxwell Brown <mxwelwbr@amazon.com>
|
I think build fails are from flaky tests but not sure. someone else pls confirm |
Galactus22625
requested review from
sb2k16,
chenqi0805,
engechas,
san81,
srikanthjg,
graytaylor0,
dinujoh,
kkondaka,
KarstenSchnitter,
dlvenable and
oeyh
as code owners
dlvenable
approved these changes
Feb 11, 2025
srikanthjg
approved these changes
Feb 13, 2025
Galactus22625
deleted the
migrate-plugins-off-of-plugin-setting-for-configuration-classes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
migrated Blocking Buffer configuration off of plugin setting
migrated StdInSource configuration off of plugin setting
Issues Resolved
Relates to issue #5246
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.