From 0749be928b5e84a33d524e874ecaff1a8e758708 Mon Sep 17 00:00:00 2001 From: Tomas Longo Date: Thu, 13 Feb 2025 14:27:47 +0100 Subject: [PATCH] Remove todos Signed-off-by: Tomas Longo --- .../plugins/otel/codec/OTelProtoCodecTest.java | 8 -------- .../plugins/source/oteltrace/OTelTraceGrpcService.java | 2 -- 2 files changed, 10 deletions(-) diff --git a/data-prepper-plugins/otel-proto-common/src/test/java/org/opensearch/dataprepper/plugins/otel/codec/OTelProtoCodecTest.java b/data-prepper-plugins/otel-proto-common/src/test/java/org/opensearch/dataprepper/plugins/otel/codec/OTelProtoCodecTest.java index 945519493a..81277f1eff 100644 --- a/data-prepper-plugins/otel-proto-common/src/test/java/org/opensearch/dataprepper/plugins/otel/codec/OTelProtoCodecTest.java +++ b/data-prepper-plugins/otel-proto-common/src/test/java/org/opensearch/dataprepper/plugins/otel/codec/OTelProtoCodecTest.java @@ -209,14 +209,6 @@ public void testParseExportTraceServiceRequest() throws IOException { validateSpans(spans); } - @Test - // TODO tlongo is this test still relevant? - public void testParseExportTraceServiceRequest_ScopeSpansTakesPrecedenceOverInstrumentationLibrarySpans() throws IOException { - final ExportTraceServiceRequest exportTraceServiceRequest = buildExportTraceServiceRequestFromJsonFile(TEST_REQUEST_BOTH_SPAN_TYPES_JSON_FILE); - final List spans = decoderUnderTest.parseExportTraceServiceRequest(exportTraceServiceRequest, Instant.now()); - validateSpans(spans); - } - @Test public void testParseExportTraceServiceRequest_NoSpans() throws IOException { final ExportTraceServiceRequest exportTraceServiceRequest = buildExportTraceServiceRequestFromJsonFile(TEST_REQUEST_NO_SPANS_JSON_FILE); diff --git a/data-prepper-plugins/otel-trace-source/src/main/java/org/opensearch/dataprepper/plugins/source/oteltrace/OTelTraceGrpcService.java b/data-prepper-plugins/otel-trace-source/src/main/java/org/opensearch/dataprepper/plugins/source/oteltrace/OTelTraceGrpcService.java index b3cb219684..e1712585e8 100644 --- a/data-prepper-plugins/otel-trace-source/src/main/java/org/opensearch/dataprepper/plugins/source/oteltrace/OTelTraceGrpcService.java +++ b/data-prepper-plugins/otel-trace-source/src/main/java/org/opensearch/dataprepper/plugins/source/oteltrace/OTelTraceGrpcService.java @@ -98,8 +98,6 @@ private void processRequest(final ExportTraceServiceRequest request, final Strea try { if (buffer.isByteBuffer()) { Map requestsMap = oTelProtoDecoder.splitExportTraceServiceRequestByTraceId(request); - // TODO tlongo remove - ExportTraceServiceRequest tmp; for (Map.Entry entry: requestsMap.entrySet()) { buffer.writeBytes(entry.getValue().toByteArray(), entry.getKey(), bufferWriteTimeoutInMillis); }