Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add functional buttons in form headers; fix query parse bug #649

Merged
merged 11 commits into from
Feb 28, 2025
Merged

Add functional buttons in form headers; fix query parse bug #649

merged 11 commits into from
Feb 28, 2025

Conversation

ohltyler
Copy link
Member

@ohltyler ohltyler commented Feb 26, 2025 •
edited
Loading

Description

This PR adds several new buttons in the form headers for performing different actions:

  • "Test flow" button which automatically opens and navigates to the "Test flow" tab in the inspector
  • "Details" button which automatically opens a flyout for the relevant resources (if created) for a particular context. On ingest, at most show the index and ingest pipeline (nest them under tabs if both found). On ingest, at most show the search pipeline
  • Update the newly-added flyouts and existing flyouts to show usage examples leveraging runtime data if found - for example, use the configured index name, ingest pipeline name, search pipeline name, and/or search query, if found.

Also:

  • moves data source version checks into a reusable custom hook
  • fixes query parsing bug which caused failures on matching strings > 1 character

Demo video, showing the updated flyouts and buttons in the form headers:

screen-capture.29.webm

Issues Resolved

Closes #656

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ohltyler
Add test flow button in form headers
76bcfbf 
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
@ohltyler ohltyler added enhancement New feature or request backport main labels Feb 26, 2025
@ohltyler ohltyler marked this pull request as draft February 26, 2025 20:11
@ohltyler
Refactor flyout into standalone component
8fbaf2e 
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
@ohltyler
More refactoring and layout updates
41cd4e7 
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
@ohltyler
Move datasourceversion fetching into custom reusable hook
98524a3 
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
@ohltyler
Remove unnecessary loading state param
4641403 
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
@ohltyler
More refactoring; set up multi-resource flyout
9a75401 
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
@ohltyler
Get multi resource flyout working and entrypoints in main flow
cc06f23 
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
@ohltyler
Fix regex replacement
72f2aaf 
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
@ohltyler
Add examples for ingest and search
67e4944 
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
@ohltyler
Propagate runtime props to flyout content
6a55e1c 
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
@ohltyler
Propagate in existing resources tab alsog
10d130c 
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
@ohltyler ohltyler changed the title Add functional buttons in form headers Add functional buttons in form headers; fix query parse bug Feb 28, 2025
@ohltyler ohltyler added the bug Something isn't working label Feb 28, 2025
@ohltyler ohltyler marked this pull request as ready for review February 28, 2025 17:02
@ohltyler ohltyler linked an issue Feb 28, 2025 that may be closed by this pull request
[BUG]Seeing error when running query with search pipeline. #656
Closed
@ohltyler ohltyler mentioned this pull request Feb 28, 2025
Open
@saimedhi saimedhi merged commit 4bfd70c into opensearch-project:2.x Feb 28, 2025
6 of 7 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 28, 2025
@github-actions
Add functional buttons in form headers; fix query parse bug (#649)
52b30b5 
* Add test flow button in form headers

Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>

* Refactor flyout into standalone component

Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>

* More refactoring and layout updates

Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>

* Move datasourceversion fetching into custom reusable hook

Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>

* Remove unnecessary loading state param

Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>

* More refactoring; set up multi-resource flyout

Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>

* Get multi resource flyout working and entrypoints in main flow

Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>

* Fix regex replacement

Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>

* Add examples for ingest and search

Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>

* Propagate runtime props to flyout content

Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>

* Propagate in existing resources tab alsog

Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>

---------

Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
(cherry picked from commit 4bfd70c)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Feb 28, 2025
Merged
saimedhi pushed a commit that referenced this pull request Feb 28, 2025
@opensearch-trigger-bot @github-actions
Add functional buttons in form headers; fix query parse bug (#649) (#658
34ff91e 
)

* Add test flow button in form headers



* Refactor flyout into standalone component



* More refactoring and layout updates



* Move datasourceversion fetching into custom reusable hook



* Remove unnecessary loading state param



* More refactoring; set up multi-resource flyout



* Get multi resource flyout working and entrypoints in main flow



* Fix regex replacement



* Add examples for ingest and search



* Propagate runtime props to flyout content



* Propagate in existing resources tab alsog



---------


(cherry picked from commit 4bfd70c)

Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@ohltyler ohltyler deleted the fixes-3 branch February 28, 2025 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saimedhi saimedhi saimedhi approved these changes

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@joshpalis joshpalis Awaiting requested review from joshpalis joshpalis is a code owner

@amitgalitz amitgalitz Awaiting requested review from amitgalitz amitgalitz is a code owner

@jackiehanyang jackiehanyang Awaiting requested review from jackiehanyang jackiehanyang is a code owner

@minalsha minalsha Awaiting requested review from minalsha minalsha is a code owner

Assignees
No one assigned
Labels
backport main bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]Seeing error when running query with search pipeline.
2 participants
@ohltyler @saimedhi