Improve RAG preset experience #617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
ohltyler
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
amitgalitz,
jackiehanyang,
minalsha and
saimedhi
as code owners
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
saimedhi
approved these changes
Feb 13, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 13, 2025
* Default ML response processors to append outputs to ext in response Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * Auto-navigate to ml outputs tab if found; minor reformatting Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * Update presets to omit ext.ml_inference Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> --------- Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> (cherry picked from commit 2d1d174) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ohltyler
pushed a commit
that referenced
this pull request
Feb 13, 2025
* Default ML response processors to append outputs to ext in response * Auto-navigate to ml outputs tab if found; minor reformatting * Update presets to omit ext.ml_inference --------- (cherry picked from commit 2d1d174) Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This improves the RAG preset experience in a few ways:
ext.ml_inferenceby default. This way, a single ML response is returned in the overall response by default for these scenarios. Existing functionality for ML response processors in other contexts, and/or when one-to-one is configured, remains unchanged.Demo video, showing the end-to-end RAG preset experience and propagation of the LLM response:
screen-capture.24.webm
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.