Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hide search query section when version is less than 2.19 #605

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

kamahuan
Copy link
Contributor

@kamahuan kamahuan commented Feb 7, 2025

Description

Hide the whole search query section for version <2.19. Refactor the code in the search_input component. According the UI screenshot, the space between search_query and search_response has been removed.

Issues Resolved

550

UI change

Xnip2025-02-06_18-26-55

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Kama Huang <kamahuan@amazon.com>
Copy link
Member

@ohltyler ohltyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ohltyler ohltyler merged commit 4e46cf3 into opensearch-project:main Feb 7, 2025
9 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 7, 2025
Signed-off-by: Kama Huang <kamahuan@amazon.com>
Co-authored-by: Kama Huang <kamahuan@amazon.com>
(cherry picked from commit 4e46cf3)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ohltyler pushed a commit that referenced this pull request Feb 7, 2025
(cherry picked from commit 4e46cf3)

Signed-off-by: Kama Huang <kamahuan@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Kama Huang <kamahuan@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants