Add fine-grained error handling; misc bug fixes #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohltyler
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
amitgalitz,
jackiehanyang,
minalsha and
saimedhi
as code owners
ohltyler
force-pushed
the
simulate-verbose
branch
from
5e883c3 to
21a5293
Compare
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
ohltyler
force-pushed
the
simulate-verbose
branch
from
4189fcd to
9334295
Compare
ohltyler
changed the title
…side Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
ohltyler
changed the title
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 6, 2025
(cherry picked from commit c9dd036) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ohltyler
pushed a commit
that referenced
this pull request
Feb 6, 2025
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Surfaces processor-level errors for both ingest and search flows. If errors are found, surface them in 2 places:
Errorstab in the Inspector, with details about which processor(s) have failed, and why.Ingest:
Adds another round of checking before data ingestion using the
verboseparameters from the simulate pipeline API: https://opensearch.org/docs/latest/ingest-pipelines/simulate-ingest/#query-parametersSearch:
If "with search pipeline" is selected, pass
verbose_pipeline=trueadded parameter to the search API call to fetch processor-level results, similar to ingest. opensearch-project/OpenSearch#16843Other improvements:
Demo video, showing the errors propagated on both ingest and search for different processor types:
screen-capture.18.webm
Issues Resolved
Closes #571
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.