Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Search Studio card in Search Overview Page #349

Merged
merged 2 commits into from
Sep 9, 2024
Merged

Adding Search Studio card in Search Overview Page #349

merged 2 commits into from
Sep 9, 2024

Conversation

saimedhi
Copy link
Collaborator

@saimedhi saimedhi commented Sep 6, 2024 •
edited
Loading

Description

  • Introducing the Search Studio card on the Search Overview Page to enhance user experience.
  • Users can navigate to Search Studio by clicking the Try OpenSearch Studio button on the Search Overview Page.
  • I will add tests in the upcoming PR.
screen-capture.18.webm

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@saimedhi saimedhi marked this pull request as ready for review September 6, 2024 21:46
ohltyler
ohltyler approved these changes Sep 9, 2024
View reviewed changes
Copy link
Member

@ohltyler ohltyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@saimedhi saimedhi merged commit 3e35af2 into opensearch-project:main Sep 9, 2024
7 of 8 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 9, 2024
@saimedhi @github-actions
Adding Search Studio card in Search Overview Page (#349)
01089f2 
Signed-off-by: saimedhi <saimedhi@amazon.com>
(cherry picked from commit 3e35af2)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Sep 9, 2024
Merged
ohltyler pushed a commit that referenced this pull request Sep 9, 2024
@opensearch-trigger-bot @saimedhi
Adding Search Studio card in Search Overview Page (#349) (#352)
c49a20b 
Signed-off-by: saimedhi <saimedhi@amazon.com>
(cherry picked from commit 3e35af2)

Co-authored-by: Sai Medhini Reddy Maryada <117196660+saimedhi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ohltyler ohltyler ohltyler approved these changes

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@joshpalis joshpalis Awaiting requested review from joshpalis joshpalis is a code owner

@amitgalitz amitgalitz Awaiting requested review from amitgalitz amitgalitz is a code owner

@jackiehanyang jackiehanyang Awaiting requested review from jackiehanyang jackiehanyang is a code owner

@minalsha minalsha Awaiting requested review from minalsha minalsha is a code owner

Assignees
No one assigned
Labels
backport 2.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saimedhi @ohltyler