Add existing indices as a source data option; improve config autofilling #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
ohltyler
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
amitgalitz,
jackiehanyang,
minalsha and
saimedhi
as code owners
saimedhi
approved these changes
Sep 5, 2024
…s optionally Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
saimedhi
approved these changes
Sep 5, 2024
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
saimedhi
approved these changes
Sep 5, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 5, 2024
…ing (#346) * Add options; auto-populate sample docs on index selection Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * onboard getmappings api; set default mappings and ml processor configs optionally Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * clear out some config on manual or uploaded doc input changes Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * change default index name for custom Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * revert overwriting of index mappings Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * revert vector field overriding Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * Move vector search check Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> --------- Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> (cherry picked from commit 6408c43)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a third option to specify the source data - from an existing index. When selected, x number of documents are automatically fetched and populated. Additionally, when data is fetched from an existing index (or from an uploaded document, attempt to prefill some config data. More specifically:
Additional improvements:
customStringify()WorkflowDetailpage so it is optimized and only called onceEuiSuperSelect->EuiCompressedSuperSelect)Demo video, showing a workflow with some sample data, then creating another workflow, building a semantic search use case on top of that existing workflow's data using the new multi-option UI for data source selection. Also shows the underlying configs updated when data is populated via manual entry or file upload. Note this does not currently overwrite any default index mappings; users will still need to ensure this is up-to-date before creating.
screen-capture.13.webm
Issues Resolved
[List any issues this PR will resolve]
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.