Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor consistency fixes #318

Merged
merged 3 commits into from
Aug 28, 2024
Merged

Minor consistency fixes #318

merged 3 commits into from
Aug 28, 2024

Conversation

ohltyler
Copy link
Member

@ohltyler ohltyler commented Aug 27, 2024 •
edited
Loading

Description

Small PR to make a few things consistent:

  1. The sample input in the input and output transform modals. Now, all scenarios will display a single input out of the array of results. This is to prevent over-using ML inference calls, and to be consistent with the produced output transform, which is only outputting a single value by default. Adds helper text in the modals as well.
  2. The text fields in the input/output transforms do not stretch by default, but the select option does (select option shows up when there is a model interface and a preset list of available input/output fields)

Screenshot of modal:

Screenshot 2024-08-27 at 4 24 01 PM

Issues Resolved

N/A

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ohltyler
Make multi inputs consistent
7e0468f 
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
@ohltyler
tune wording
d1246a5 
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
@ohltyler
tune
e9ca7cc 
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
@ohltyler ohltyler merged commit 1e2ede0 into opensearch-project:main Aug 28, 2024
6 checks passed
@ohltyler ohltyler deleted the multi-input-bug-fix branch August 28, 2024 00:15
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 28, 2024
@ohltyler @github-actions
Minor consistency fixes (#318)
27daf8b 
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
(cherry picked from commit 1e2ede0)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Aug 28, 2024
Merged
ohltyler added a commit that referenced this pull request Aug 28, 2024
@opensearch-trigger-bot @ohltyler
Minor consistency fixes (#318) (#319)
022fedb 
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
(cherry picked from commit 1e2ede0)

Co-authored-by: Tyler Ohlsen <ohltyler@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshpalis joshpalis joshpalis approved these changes

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@amitgalitz amitgalitz Awaiting requested review from amitgalitz amitgalitz is a code owner

@jackiehanyang jackiehanyang Awaiting requested review from jackiehanyang jackiehanyang is a code owner

@minalsha minalsha Awaiting requested review from minalsha minalsha is a code owner

@saimedhi saimedhi Awaiting requested review from saimedhi saimedhi is a code owner

Assignees
No one assigned
Labels
backport 2.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ohltyler @joshpalis