Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MDS Version Decoupling #314

Merged
merged 2 commits into from
Aug 27, 2024
Merged

MDS Version Decoupling #314

merged 2 commits into from
Aug 27, 2024

Conversation

saimedhi
Copy link
Collaborator

@saimedhi saimedhi commented Aug 26, 2024 •
edited
Loading

Description

This PR filters out the versions which are not supported when MDS support is enabled

Tested Below

screen-capture.17.webm

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@saimedhi
MDS Version Decoupling
e6bc07c 
Signed-off-by: saimedhi <saimedhi@amazon.com>
@saimedhi saimedhi marked this pull request as ready for review August 26, 2024 23:09
ohltyler
ohltyler approved these changes Aug 27, 2024
View reviewed changes
Copy link
Member

@ohltyler ohltyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! LGTM, thanks for adding

@ohltyler ohltyler merged commit 5828295 into opensearch-project:main Aug 27, 2024
5 of 6 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 27, 2024
@saimedhi @github-actions
MDS Version Decoupling (#314)
238fcfc 
Signed-off-by: saimedhi <saimedhi@amazon.com>
(cherry picked from commit 5828295)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Aug 27, 2024
Merged
ohltyler pushed a commit that referenced this pull request Aug 27, 2024
@opensearch-trigger-bot @saimedhi
MDS Version Decoupling (#314) (#316)
29391c1 
Signed-off-by: saimedhi <saimedhi@amazon.com>
(cherry picked from commit 5828295)

Co-authored-by: Sai Medhini Reddy Maryada <117196660+saimedhi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ohltyler ohltyler ohltyler approved these changes

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@joshpalis joshpalis Awaiting requested review from joshpalis joshpalis is a code owner

@amitgalitz amitgalitz Awaiting requested review from amitgalitz amitgalitz is a code owner

@jackiehanyang jackiehanyang Awaiting requested review from jackiehanyang jackiehanyang is a code owner

@minalsha minalsha Awaiting requested review from minalsha minalsha is a code owner

Assignees
No one assigned
Labels
backport 2.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saimedhi @ohltyler