Refine 'Search Studio' URL handling in Side Nav with NewHomePage enabled #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: saimedhi <saimedhi@amazon.com>
saimedhi
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
ohltyler,
amitgalitz,
jackiehanyang and
minalsha
as code owners
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 27, 2024
Signed-off-by: saimedhi <saimedhi@amazon.com> (cherry picked from commit c8faaf7)
ohltyler
pushed a commit
that referenced
this pull request
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolved the following issue:
When 'Search Studio' is selected from the SideNav on the 'workflow detail' page, the page was not redirecting to the 'workflows' page.
Below screen Recording shows the issue that I am trying to resolve.
screen-capture.15.webm
The dashboards-flow-framework uses a hash router. To ensure proper redirection, the hash has been added at the end of the URL.
Issue Resolved here and can be seen in below screen recording.
screen-capture.16.webm
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.