Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] Adding provision to invoke stop-replication from other plugins #1502

Open
wants to merge 2 commits into
base: 2.x
Choose a base branch
from

Conversation

aggarwalShivani
Copy link
Contributor

Description

Backport of #1391 on 2.x branch. Pls see the PR on main branch for complete background.
Mainly, the changes are ->

  • StopIndexReplicationAction and StopIndexReplicationRequest are moved from the ccr project to common-utils. (Common-utils change PR)
  • Added a new transport action, TransportInternalStopIndexReplicationAction - that can be used by other plugins like ism, to invoke stop-replication.

Related Issues

Stop replication feature in ism

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: aggarwalShivani <shivani.aggarwal@nokia.com>
Signed-off-by: aggarwalShivani <shivani.aggarwal@nokia.com>
@aggarwalShivani
Copy link
Contributor Author

Currently, CI checks are failing as required changes in common-utils PR are not yet merged.

@aggarwalShivani
Copy link
Contributor Author

Hi @ankitkala

Looks like, unlike other plugins, the ccr plugin zipfiles do not get published anymore at this link -
https://aws.oss.sonatype.org/content/repositories/snapshots/org/opensearch/plugin/opensearch-cross-cluster-replication, even though i see build.sh has the publish task.

Can you pls guide here on what is missing?

As part of this feature, we want to install ccr-plugin during integTest stage in ism plugin. Pls see for reference. Pls guide on how this can be achieved.

@aggarwalShivani
Copy link
Contributor Author

Hi @ankitkala

Looks like, unlike other plugins, the ccr plugin zipfiles do not get published anymore at this link - https://aws.oss.sonatype.org/content/repositories/snapshots/org/opensearch/plugin/opensearch-cross-cluster-replication, even though i see build.sh has the publish task.

Can you pls guide here on what is missing?

Hi @ankitkala
Any suggestions here?

Copy link
Member

@bowenlan-amzn bowenlan-amzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -324,7 +325,7 @@ abstract class MultiClusterRestTestCase : OpenSearchTestCase() {
"indices:admin/plugins/replication/index/start",
"indices:admin/plugins/replication/index/pause",
"indices:admin/plugins/replication/index/resume",
"indices:admin/plugins/replication/index/stop",
"$STOP_REPLICATION_ACTION_NAME",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to clarify, if user wants to use CCR in ISM in a security enabled cluster, they will still need the internal replication action allowed, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants