-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding replication (CCR) plugin interface and classes to common-utils #667
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: aggarwalShivani <shivani.aggarwal@nokia.com>
src/main/kotlin/org/opensearch/commons/replication/action/ReplicationActions.kt
Show resolved
Hide resolved
Signed-off-by: aggarwalShivani <shivani.aggarwal@nokia.com>
Signed-off-by: aggarwalShivani <shivani.aggarwal@nokia.com>
src/main/kotlin/org/opensearch/commons/replication/action/ReplicationActions.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/org/opensearch/commons/replication/ReplicationPluginInterface.kt
Show resolved
Hide resolved
src/test/kotlin/org/opensearch/commons/replication/ReplicationPluginInterfaceTests.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: aggarwalShivani <shivani.aggarwal@nokia.com>
Hi, |
…lasses Signed-off-by: aggarwalShivani <shivani.aggarwal@nokia.com>
The integration issue of common-utils and ccr is resolved with the merge of this change in ccr. Meanwhile, as the changes for the stop-replication feature for both common-utlis and ccr are ready, requesting your review on this. |
/** | ||
* Transport action plugin interfaces for the cross-cluster-replication plugin. | ||
*/ | ||
open class ReplicationPluginInterface { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
open class ReplicationPluginInterface { | |
object ReplicationPluginInterface { | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feels like the methods here should just be static methods.
Description
Background:
Proposed Solution:
(FYI - This is an alternative approach for this feature. I had also raised a draft PR with a different approach, but we didnt go ahead with it as it required changes in opensearch-core as well.)
Change description:
Code for StopIndexReplicationRequest and StopIndexReplicationAction are moved to common-utils. Added UTs for both the new classes added.
This PR caters to point 1 of the proposed solution.
Issues Resolved
Related Issues
unfollow-action #726
Check List
[ ] New functionality has been documented.[ ] New functionality has javadoc addedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.